Replacing the options menu in user mods

Here, developers communicate stuff that does not go onto the main News section or the front page of the site.
[Dev Blog] [Development Builds] [Git Change Log]

Moderator: Developers

Re: Replacing the options menu in user mods

Postby Graf Zahl » Mon Jun 12, 2017 2:14 am

Nash wrote:Graf, stop it with these imaginary enemies.


ZZYZX started with them, I just responed to his hypothetical question. I think most people are reasonable enough not to do such shit but I guess you know the term "Terrywad", don't you?
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Replacing the options menu in user mods

Postby Nash » Mon Jun 12, 2017 2:16 am

I don't download Terrywads, and if something ends up being a Terrwad, off to the bin it quickly goes :twisted:
User avatar
Nash
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia

Re: Replacing the options menu in user mods

Postby Gez » Mon Jun 12, 2017 3:36 am

GFD wrote:(See: this comic edit Ed the Bat found.)

It's about PrBoom's menus.

Spoiler:
Gez
 
 
 
Joined: 06 Jul 2007

Re: Replacing the options menu in user mods

Postby Graf Zahl » Mon Jun 12, 2017 3:51 am

The main problem with PrBoom's menus, aside from the inconsistent visuals, is that "Options" leads to "General" which is a seemingly endless list of options that should be grouped into multiple submenus instead of letting the user wade through multiple pages of haphazardly lumped together options.

I never liked that design and already fixed some similar parts in ZDoom's menus many years ago. Some parts were a lot worse than they are now.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Replacing the options menu in user mods

Postby Blue Shadow » Mon Jun 12, 2017 10:29 am

Are sub-menus excluded from the merge?

In an old version of my NC HUD, I have this menudef:

Code: Select allExpand view
OptionMenu "HUDOptions"
{
  Title "HUD Options"
  Submenu "Alternative HUD", "AltHudOptions"
  Submenu "NC HUD", "NCHUD" // <--- HUD's sub-menu.
  Submenu "Message Options", "MessageOptions"
  StaticText " "
  Option "Default Crosshair", "crosshair", "Crosshairs"
  Option "Force default crosshair", "crosshairforce", "OnOff"
  Option "Grow crosshair when picking up items", "crosshairgrow", "OnOff"
  ColorPicker "Crosshair color", "crosshaircolor"
  Option "Crosshair shows health", "crosshairhealth", "OnOff"
  Option "Scale crosshair", "crosshairscale", "OnOff"
  StaticText " "
  Option "Display nametags", "displaynametags", "DisplayTagsTypes"
  Option "Nametag color", "nametagcolor", "TextColors", "displaynametags"
  Option "Stretch status bar", "st_scale", "OnOff"
  Option "Stretch Fullscreen HUD", "hud_scale", "OnOff"
  Option "Use old ouch mug shot formula", "st_oldouch", "OnOff"
  StaticText " "
  Option "Hexen weapon flashes", "pf_hexenweaps", "ZDoomHexen"
  Option "Poison damage flashes", "pf_poison", "ZDoomHexen"
  Option "Ice death flashes", "pf_ice", "ZDoomHexen"
  Option "Poison Buildup flashes", "pf_hazard",    "ZDoomStrife"
}

OptionMenu "NCHUD"
{
  Title "NC HUD"
  Option "Toggle tally display?", "nchud_toggletally", "YesNo"
  Option "Toggle reserve ammo display?", "nchud_toggleammo", "YesNo"
  StaticText " "
  Option "Toggle old bar system?", "nchud_oldbarsystem", "YesNo"
  TextField "Blue bar maxes out at", "nchud_overmaxbar", "nchud_oldbarsystem"
}

But the sub-menu is not showing anymore (using 3.2pre-64-g2ff492d, by the way).
Last edited by Blue Shadow on Mon Jun 12, 2017 10:37 am, edited 1 time in total.
Reason: Added more info.
User avatar
Blue Shadow
 
 
 
Joined: 14 Nov 2010

Re: Replacing the options menu in user mods

Postby Graf Zahl » Mon Jun 12, 2017 10:35 am

The merging applies to all menus that are declared 'protected' in MENUDEF. That means all submenus of Options except the player menu.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Replacing the options menu in user mods

Postby Blue Shadow » Mon Jun 12, 2017 10:38 am

I added more information to my post above.
User avatar
Blue Shadow
 
 
 
Joined: 14 Nov 2010

Re: Replacing the options menu in user mods

Postby Graf Zahl » Mon Jun 12, 2017 10:43 am

Looks like a simple oversight. It tries to cull dead items but for submenus that's not working if the menu is forward declared because it cannot find the menu when it's being checked. The check either needs to be removed or done later.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Replacing the options menu in user mods

Postby Graf Zahl » Mon Jun 12, 2017 11:34 am

@Xaser:

I deleted your rant because if you are unwilling to even READ what others write, your response to that is better forgotten.

Just this: The Square menu has been broken since the 3.0 release, which made significant changes to some parts of the options menus. I noticed that it was broken two days ago and to prevent such broken menus from causing problems implemented a countermeasure.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Replacing the options menu in user mods

Postby wildweasel » Mon Jun 12, 2017 11:35 am

Graf Zahl wrote:@Xaser:

I deleted your rant because if you are unwilling to even READ what others write, your response to that is better forgotten.

The staff were in the middle of discussing what to do about it. Let the forum staff handle staff matters, please. I'm not pleased with the way you've been using the moderator tools to quash discussions instead of allowing the moderators to moderate.
User avatar
wildweasel
I love the smell of sourdough in the morning
 
Joined: 15 Jul 2003
Location: avatar by kurashiki

Re: Replacing the options menu in user mods

Postby Graf Zahl » Mon Jun 12, 2017 11:36 am

I was hoping to get rid of it before such action was taken... :?
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Replacing the options menu in user mods

Postby Kinsie » Mon Jun 12, 2017 11:43 am

Graf Zahl wrote:I was hoping to get rid of it before such action was taken... :?
Seriously, dude?
User avatar
Kinsie
Glarepokes (thx Kura-san!)
 
Joined: 22 Oct 2004
Location: MAP33
Discord: Find Me

Re: Replacing the options menu in user mods

Postby Rachael » Mon Jun 12, 2017 12:00 pm

This discussion is bringing out the worst in us, I think it's time for it to end.

I am very disappointed with how this is being handled - especially by everyone involved in the later parts of it. You all should know better by now, and this constant rip-and-tearing at each other's necks is not doing anything productive.

Please, for the love of this game and the source port, DON'T hit the "Submit" button when you are upset!

We will be talking with the involved parties a little more in-depth privately, later.
User avatar
Rachael
Not all elves needs a stocking hat...
 
Joined: 13 Jan 2004

Previous

Return to Developer Blog

Who is online

Users browsing this forum: No registered users and 1 guest