Smooth Weapons Enhanced [v3.2.1]

Projects that alter game functions but do not include new maps belong here.
Forum rules
The Projects forums are ONLY for YOUR PROJECTS! If you are asking questions about a project, either find that project's thread, or start a thread in the General section instead.

Got a cool project idea but nothing else? Put it in the project ideas thread instead!

Projects for any Doom-based engine (especially 3DGE) are perfectly acceptable here too.

Please read the full rules for more details.

Re: Smooth Weapons Enhanced [v3.2.1]

Postby m8f » Mon Jun 28, 2021 10:01 am

I'm not sure why, but renaming perk_enhanced.pk3/zscript/doom1.zc and perk_enhanced.pk3/zscript/doom2.zc to pkdoom1.zc and pkdoom2.zc respectively (and changing ZScript include directives in filter directories) allows Smooth Weapons Enhanced to load with Wadsmoosh. It's worth investigating.
User avatar
m8f
dreamer
 
 
 
Joined: 29 Dec 2017
Location: Siberia (UTC+7)
Discord: m8f#0629
Github ID: mmaulwurff
Operating System: Debian-like Linux (Debian, Ubuntu, Mint, etc) 64-bit

Re: Smooth Weapons Enhanced [v3.2.1]

Postby NightFright » Mon Jun 28, 2021 11:39 am

That's weird. The error is only about the fist and pistol replacements, but if doom1.zc and doom2.zc only load if renamed, the other weapons also shouldn't load... Well, both weapons are given to player by default. Maybe that's where to look.

But why is it only happening in WadSmoosh and not regular D1/D2?
User avatar
NightFright
Spotlight Team
 
Joined: 02 May 2008
Location: Germany

Re: Smooth Weapons Enhanced [v3.2.1]

Postby strangebit » Tue Jun 29, 2021 1:36 am

This happened because GZDoom 4.6.0 changed the AutoName for WadSmoosh (within game_support.pk3/iwadinfo.txt):
doom.id.doom2.wadsmoosh -> doom.id.wadsmoosh

So now the doom.id.doom2 lumps within Smooth Weapons Enhanced are no longer loaded with WadSmoosh. Nothing complicated.

I created a pull request for this:
https://github.com/NightFright2k19/gzdo ... ed/pull/13

I guess it wasn't noticed because I made it a draft pull request. Does that not send out notifications? I don't really have any experience with doom modding so I wanted it to be open to discussion first before merging. :mrgreen:
strangebit
 
Joined: 23 Apr 2020

Re: Smooth Weapons Enhanced [v3.2.1]

Postby NightFright » Tue Jun 29, 2021 9:26 am

Well, that pull request is currently a draft, so it cannot be merged. I will take a look if Nash doesn't have the time in the next few days.
User avatar
NightFright
Spotlight Team
 
Joined: 02 May 2008
Location: Germany

Re: Smooth Weapons Enhanced [v3.2.1]

Postby Nash » Tue Jun 29, 2021 9:34 am

If it's just about the filter name, that's a trivival thing and can be merged.

Though, I'll have to say, I recommend, for normal play, to not go beyond this commit: https://github.com/NightFright2k19/gzdo ... e8cf99c249

Everything after that is highly WIP, and in hindsight, I should not have worked on the master branch, but rather, a separate sandbox branch.
User avatar
Nash
Twitter/Facebook/Youtube: nashmuhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Twitch ID: nashmuhandes
Github ID: nashmuhandes

Re: Smooth Weapons Enhanced [v3.2.1]

Postby strangebit » Tue Jun 29, 2021 9:52 am

Nash wrote:If it's just about the filter name, that's a trivival thing and can be merged.

Though, I'll have to say, I recommend, for normal play, to not go beyond this commit: https://github.com/NightFright2k19/gzdo ... e8cf99c249

Everything after that is highly WIP, and in hindsight, I should not have worked on the master branch, but rather, a separate sandbox branch.

Yeah I noticed that it looked WIP, but I can't make a PR to merge into anything other than master. But because of that, I did make a separate changeset on top of tag-v3.2.1 (which is one commit behind the one you specified). Not part of the PR, but ready to go if you prefer it. If you make a new branch off of tag-v3.2.1, I could then submit another pull request using that branch as the base, and then you can work with that however you like.
strangebit
 
Joined: 23 Apr 2020

Re: Smooth Weapons Enhanced [v3.2.1]

Postby NightFright » Tue Jun 29, 2021 11:45 pm

I have done the merge. Please check if it works now. I think I merged it into the latest version, however. Hopefully it's not too bad.
User avatar
NightFright
Spotlight Team
 
Joined: 02 May 2008
Location: Germany

Re: Smooth Weapons Enhanced [v3.2.1]

Postby strangebit » Wed Jun 30, 2021 1:37 am

Okay cool thanks. If you still want the backport later on let me know, or if you prefer to do it yourself that's fine.
strangebit
 
Joined: 23 Apr 2020

Re: Smooth Weapons Enhanced [v3.2.1]

Postby ESTIERCOL » Thu Jul 01, 2021 2:08 am

NightFright wrote:I have done the merge. Please check if it works now. I think I merged it into the latest version, however. Hopefully it's not too bad.


works fine now! thanks!
User avatar
ESTIERCOL
 
Joined: 26 Jan 2020
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Previous

Return to Gameplay Mods

Who is online

Users browsing this forum: Dutchygamer, Pachira, PresBarackbar and 11 guests