[Addressed] [0.4.1-8374b9e] Game says incorrect key following death

Moderator: Raze Developers

[0.4.1-8374b9e] Game says incorrect key following death

Postby mjr4077au » Mon Feb 10, 2020 4:05 am

When playing the game and you die, the game erroneously says to press 'space' to reload, however I have 'E' bound as my use key. In EDuke32, it says to press the use key to reload.
User avatar
mjr4077au
 
Joined: 17 Jun 2019
Location: Gosford NSW, Australia
Discord: mjr4077au#1027
Github ID: mjr4077au
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [0.4.1-8374b9e] Game says incorrect key following death

Postby sinisterseed » Mon Feb 10, 2020 4:16 am

The funny thing here is that in some games, if you remove the strings they will mention space bar to restart the map.

This is the case of SW, where if the string for this action is removed it'll simply read "TXT_SPACEBAR". I agree that it should be changed to reflect the current key assigned to the "Use" action.
User avatar
sinisterseed
GZDoom RO Translator & Raze Tester
 
Joined: 05 Nov 2019
Twitch ID: sixhundredsixteen
Github ID: sinisterseed
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [0.4.1-8374b9e] Game says incorrect key following death

Postby mjr4077au » Mon Feb 10, 2020 4:23 am

Maybe that's what's happened then as part of the effort to internationalise the texts.
User avatar
mjr4077au
 
Joined: 17 Jun 2019
Location: Gosford NSW, Australia
Discord: mjr4077au#1027
Github ID: mjr4077au
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [0.4.1-8374b9e] Game says incorrect key following death

Postby Graf Zahl » Mon Feb 10, 2020 4:34 am

What happened here is that I removed the hack to replace the "space" part of the text, because it didn't play well with the localization effort.
To allow translating the quotes, this works as follows: It takes the original quote text, turns it into a string label and then looks up the real text in the string table. But this is no longer English only, it can be everything - especially "space" no longer needs to be "space" - this key name substitution feature needs to be entirely redone to be compatible with that.
But like so many other things, this is a secondary concern and will be looked into when the bug list shortens.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [0.4.1-8374b9e] Game says incorrect key following death

Postby mjr4077au » Mon Feb 10, 2020 4:58 am

No worries, I knew you'd be all over it ;)
User avatar
mjr4077au
 
Joined: 17 Jun 2019
Location: Gosford NSW, Australia
Discord: mjr4077au#1027
Github ID: mjr4077au
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [0.4.1-8374b9e] Game says incorrect key following death

Postby Graf Zahl » Sun Oct 11, 2020 12:32 pm

I've changed all affected texts to use "Press 'Use'" In German it was already correct, unfortunately the Portuguese translation still uses "Space" everywhere and a few Romanian texts, too.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests