[Fixed] Missing key on Fleshed Out E3M6

Moderator: Raze Developers

Missing key on Fleshed Out E3M6

Postby SaveTheDoomer » Sat Apr 17, 2021 12:55 am

On E3M6 of Fleshed Out the final cerberus should drop a key 7 when killed, but it doesn't, so the map cannot be completed. Previously raze used to crash on this point, now it seems to be fixed. Tried to play with Bloodgdx and the key is dropped correctly.
The link to the mod is the following: https://www.moddb.com/mods/blood-fleshed-out/downloads/fleshed-out-v17
User avatar
SaveTheDoomer
 
Joined: 11 Apr 2021
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: Missing key on Fleshed Out E3M6

Postby SaveTheDoomer » Sat Apr 17, 2021 1:22 am

Tried to add a savegame, but it is too big.
User avatar
SaveTheDoomer
 
Joined: 11 Apr 2021
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: Missing key on Fleshed Out E3M6

Postby Graf Zahl » Sat Apr 17, 2021 1:55 am

Please upload it elsewhere and post a link here. It's a bit much to play a level I do not know yet to fInd a place I do not know where to look for. 'So the save would help a lot.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Missing key on Fleshed Out E3M6

Postby SaveTheDoomer » Sat Apr 17, 2021 2:01 am

Ok, don't you worry, nevermind. Thanks anyway.
User avatar
SaveTheDoomer
 
Joined: 11 Apr 2021
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: Missing key on Fleshed Out E3M6

Postby SaveTheDoomer » Sat Apr 17, 2021 2:21 am

User avatar
SaveTheDoomer
 
Joined: 11 Apr 2021
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: Missing key on Fleshed Out E3M6

Postby Graf Zahl » Sat Apr 17, 2021 2:24 am

Thanks. I'll look into it ASAP. The crash fix was only half the story - the condition should never trigger, actually, but I never had a place where to reliably test the causes leading up to it.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Missing key on Fleshed Out E3M6

Postby Graf Zahl » Sat Apr 17, 2021 3:41 am

Ok, so how is this supposed to work?
This seventh key has no sprite image attached.
In NBlood its picnum was -1, that's what was causing the crash. In GDX it is set to 0 which is a brick wall texture. Trying to use a picture one after the 6th key just gives an oversized key outline.
It is the only item in the entire item list that looks invalid.

I can pick up the key with any invalid image, but what does the DOS version do here?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Missing key on Fleshed Out E3M6

Postby SaveTheDoomer » Sat Apr 17, 2021 3:53 am

Yes, the seventh key looks like a "ghost" blue key outline. I never saw it in the base game or cryptic passage, but in some mod like Death wish it is used to unlock the secret level. In Fleshed out the seventh key is used on a lot of levels, in this particular level is needed to trigger the dynamite at the end of the level, and is dropped by the cerberus upon killing it. In every other level it worked, for some reason the cerberus doesn't drop it here.
User avatar
SaveTheDoomer
 
Joined: 11 Apr 2021
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: Missing key on Fleshed Out E3M6

Postby Graf Zahl » Sat Apr 17, 2021 4:03 am

I think it works if it gets placed on the map with the proper picnum and scale manually set. But the cerberus drops it and it takes the picnum from an internal record - and that record was not properly filled in.
Which resulted in the spawned key having bad scale and a bad image. In NBlood this will most likely crash as well and in GDX the sprite will be invisible as set up, and I cannot find any further special handling in either port.

I think under these circumstances, setting it up as the same key outline sprite will be most consistent with what users may expect.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Missing key on Fleshed Out E3M6

Postby SaveTheDoomer » Sat Apr 17, 2021 4:14 am

User avatar
SaveTheDoomer
 
Joined: 11 Apr 2021
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: Missing key on Fleshed Out E3M6

Postby Graf Zahl » Sat Apr 17, 2021 4:22 am

Yeah, random luck. It still has an out of bounds array access but normally doesn't seem to cause the crash it does in Raze because many of these arrays have been refactored into other data structures where OOB is a fatal error.

But the key still is not visible there. It is one of the two scenarios I considered possible for NBlood, it depended on what random data it read for the invalid picnum.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Missing key on Fleshed Out E3M6

Postby SaveTheDoomer » Sat Apr 17, 2021 4:34 am

Replayed the level in gdx. The key is invisible, yet it's there. It's the most weird key placement i've ever seen :|
User avatar
SaveTheDoomer
 
Joined: 11 Apr 2021
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: Missing key on Fleshed Out E3M6

Postby Graf Zahl » Sat Apr 17, 2021 4:38 am

I can only guess, but maybe Fresh Supply has a valid data record there and if that was the primary testing platform the problem would never have shown.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Missing key on Fleshed Out E3M6

Postby SaveTheDoomer » Sat Apr 17, 2021 4:44 am

Recompiled and replayed, now the issue is fixed, thank you! :D
User avatar
SaveTheDoomer
 
Joined: 11 Apr 2021
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests