Music definitions do not work

Moderator: Raze Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
Gez
 
 
Posts: 17831
Joined: Fri Jul 06, 2007 3:22 pm

Music definitions do not work

Post by Gez »

I'm talking about this unofficial add-on. I'm not managing to get it to work.

First attempt, just drag-and-dropping the zip. Fails. Too bad.
Second attempt, extracting the content, making a bat file as suggested, except with raze instead of eduke32:

Code: Select all

raze.exe /gdukedc.grp /gdukedc_music.zip
Fails also.

Extract zip content, drag-and-drop extracted directory. Still fails.

At this point I'm thinking of directly editing dukedc.grp, but 1) I have zero experience of Build editing and 2) AFAIK data files are identified by their checksums so any modification would make it no longer be recognized.
Last edited by Gez on Wed Mar 04, 2020 5:18 pm, edited 1 time in total.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49053
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Help with Duke in DC music pack

Post by Graf Zahl »

What does "fails" mean? How far do you get?
Gez
 
 
Posts: 17831
Joined: Fri Jul 06, 2007 3:22 pm

Re: Help with Duke in DC music pack

Post by Gez »

Fails means that the menu screen plays GRABBAG instead of TBSS, and when I start the first map of the extension (third episode, replacing Shrapnel City) and hear INHIDING.MID instead of LIBERTY.

I even tried editing the duke3d.def file from dukedc_music20.zip to comment out the parts where it includes HRP stuff, because it caused error messages in Raze's console. Also to make it load the MIDI instead of the OGG. To no avail.

The graphic replacement does work, though. I do get 2456_dc.bmp to display. Not sure about the sound replacements. The soundtrack definition doesn't work.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49053
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Help with Duke in DC music pack

Post by Graf Zahl »

Any info in the console?
Gez
 
 
Posts: 17831
Joined: Fri Jul 06, 2007 3:22 pm

Re: Help with Duke in DC music pack

Post by Gez »

Nothing useful.

I get the usual complaints about "else with no if" in ORGANTIC and pigshootenemystate from the standard CON files, then (if using the original zip) two warnings about failing including duke3D_hrp.def on duke3D.def:3 and :4 and then nothing. I set "developer" to 1 but it doesn't produce more messages.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49053
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Help with Duke in DC music pack

Post by Graf Zahl »

Ok, that most likely means that the data is not written to the proper place.
Gez
 
 
Posts: 17831
Joined: Fri Jul 06, 2007 3:22 pm

Re: Music definitions do not work

Post by Gez »

I'm taking this as confirmation it's a bug and not PEBCAC.
markanini
Posts: 208
Joined: Sat Jan 18, 2020 6:10 am

Re: Music definitions do not work

Post by markanini »

I can confim, in 0.5.1 the new music isn't loaded, and midi device selection and cd music toggle still operate when they should be overriden. I checked with printfs comand to confirm the file was loaded, I suspect the definition file isn't being interpreted.
User avatar
sinisterseed
Posts: 1349
Joined: Tue Nov 05, 2019 6:48 am
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support
Contact:

Re: Music definitions do not work

Post by sinisterseed »

markanini wrote:I can confim, in 0.5.1 the new music isn't loaded, and midi device selection and cd music toggle still operate when they should be overriden. I checked with printfs comand to confirm the file was loaded, I suspect the definition file isn't being interpreted.
I've also checked this and honestly I think NBlood's approach is the flawed one in this particular case with CD music in Blood: https://www.doomworld.com/forum/topic/1 ... nt-2096172
Actually, if anything, I think NBlood is the one doing it wrong. I just took a look at the .def file's code and nothing inside it points to such behavior, so unless proven otherwise, I think Raze is right in its approach. The fact that the sound toggle itself also becomes unusable with the package loaded further highlights this, that should definitely not be happening (ye, I just tested it myself in NBlood too).

This is the code inside the .def file:

Code: Select all

music { id "CBLOOD1" file "music/CBLOOD1.ogg" }
music { id "CBLOOD2" file "music/CBLOOD2.ogg" }
music { id "CBLOOD3" file "music/CBLOOD3.ogg" }
music { id "CBLOOD4" file "music/CBLOOD4.ogg" }
music { id "CBLOOD5" file "music/CBLOOD5.ogg" }
music { id "CBLOOD6" file "music/CBLOOD6.ogg" }
music { id "CBLOOD7" file "music/CBLOOD7.ogg" }
music { id "CBLOOD8" file "music/CBLOOD8.ogg" }
music { id "CBLOOD9" file "music/CBLOOD9.ogg" }
music { id "CBLOOD10" file "music/CBLOOD10.ogg" }
music { id "UNHOLY" file "music/UNHOLY.ogg" }
music { id "PESTIS" file "music/PESTIS.ogg" }
It's just simple paths to the music, nothing that takes the control away from the user in an abusive way.
Gammli
Posts: 47
Joined: Sat Mar 02, 2019 12:46 am

Re: Music definitions do not work

Post by Gammli »

The reason the music doesn't load is because Raze does not interpret the following as a relative path:

Code: Select all

music { id "intro" file "dukedc/music/tbss.ogg" }
and the fix really is as simple as changing it to the following:

Code: Select all

music { id "intro" file "./dukedc/music/tbss.ogg" }
Otherwise the file structure works fine.
Gez
 
 
Posts: 17831
Joined: Fri Jul 06, 2007 3:22 pm

Re: Music definitions do not work

Post by Gez »

Oh, that's it? Thanks.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49053
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Music definitions do not work

Post by Graf Zahl »

Thanks for that piece of info. I'll fix it ASAP.
Gez
 
 
Posts: 17831
Joined: Fri Jul 06, 2007 3:22 pm

Re: Music definitions do not work

Post by Gez »

I gave this another try in 0.8.1 and it still doesn't work.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49053
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Music definitions do not work

Post by Graf Zahl »

Not surprising because I haven't touched that code.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49053
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Music definitions do not work

Post by Graf Zahl »

Finally got fixed. Sorry it took over a year...
Post Reply

Return to “Closed Bugs [Raze]”