Music definitions do not work

Moderator: Raze Developers

Music definitions do not work

Postby Gez » Tue Mar 03, 2020 5:02 am

I'm talking about this unofficial add-on. I'm not managing to get it to work.

First attempt, just drag-and-dropping the zip. Fails. Too bad.
Second attempt, extracting the content, making a bat file as suggested, except with raze instead of eduke32:
Code: Select allExpand view
raze.exe /gdukedc.grp /gdukedc_music.zip

Fails also.

Extract zip content, drag-and-drop extracted directory. Still fails.

At this point I'm thinking of directly editing dukedc.grp, but 1) I have zero experience of Build editing and 2) AFAIK data files are identified by their checksums so any modification would make it no longer be recognized.
Last edited by Gez on Wed Mar 04, 2020 5:18 pm, edited 1 time in total.
Gez
 
 
 
Joined: 06 Jul 2007

Re: Help with Duke in DC music pack

Postby Graf Zahl » Tue Mar 03, 2020 5:23 am

What does "fails" mean? How far do you get?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Help with Duke in DC music pack

Postby Gez » Tue Mar 03, 2020 6:23 am

Fails means that the menu screen plays GRABBAG instead of TBSS, and when I start the first map of the extension (third episode, replacing Shrapnel City) and hear INHIDING.MID instead of LIBERTY.

I even tried editing the duke3d.def file from dukedc_music20.zip to comment out the parts where it includes HRP stuff, because it caused error messages in Raze's console. Also to make it load the MIDI instead of the OGG. To no avail.

The graphic replacement does work, though. I do get 2456_dc.bmp to display. Not sure about the sound replacements. The soundtrack definition doesn't work.
Gez
 
 
 
Joined: 06 Jul 2007

Re: Help with Duke in DC music pack

Postby Graf Zahl » Tue Mar 03, 2020 7:03 am

Any info in the console?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Help with Duke in DC music pack

Postby Gez » Tue Mar 03, 2020 7:24 am

Nothing useful.

I get the usual complaints about "else with no if" in ORGANTIC and pigshootenemystate from the standard CON files, then (if using the original zip) two warnings about failing including duke3D_hrp.def on duke3D.def:3 and :4 and then nothing. I set "developer" to 1 but it doesn't produce more messages.
Gez
 
 
 
Joined: 06 Jul 2007

Re: Help with Duke in DC music pack

Postby Graf Zahl » Tue Mar 03, 2020 7:39 am

Ok, that most likely means that the data is not written to the proper place.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Music definitions do not work

Postby Gez » Wed Mar 04, 2020 5:19 pm

I'm taking this as confirmation it's a bug and not PEBCAC.
Gez
 
 
 
Joined: 06 Jul 2007

Re: Music definitions do not work

Postby markanini » Mon Mar 16, 2020 6:58 am

I can confim, in 0.5.1 the new music isn't loaded, and midi device selection and cd music toggle still operate when they should be overriden. I checked with printfs comand to confirm the file was loaded, I suspect the definition file isn't being interpreted.
markanini
 
Joined: 18 Jan 2020

Re: Music definitions do not work

Postby sinisterseed » Mon Mar 16, 2020 7:37 am

markanini wrote:I can confim, in 0.5.1 the new music isn't loaded, and midi device selection and cd music toggle still operate when they should be overriden. I checked with printfs comand to confirm the file was loaded, I suspect the definition file isn't being interpreted.

I've also checked this and honestly I think NBlood's approach is the flawed one in this particular case with CD music in Blood: https://www.doomworld.com/forum/topic/1 ... nt-2096172

Actually, if anything, I think NBlood is the one doing it wrong. I just took a look at the .def file's code and nothing inside it points to such behavior, so unless proven otherwise, I think Raze is right in its approach. The fact that the sound toggle itself also becomes unusable with the package loaded further highlights this, that should definitely not be happening (ye, I just tested it myself in NBlood too).

This is the code inside the .def file:
Code: Select allExpand view
music { id "CBLOOD1" file "music/CBLOOD1.ogg" }
music { id "CBLOOD2" file "music/CBLOOD2.ogg" }
music { id "CBLOOD3" file "music/CBLOOD3.ogg" }
music { id "CBLOOD4" file "music/CBLOOD4.ogg" }
music { id "CBLOOD5" file "music/CBLOOD5.ogg" }
music { id "CBLOOD6" file "music/CBLOOD6.ogg" }
music { id "CBLOOD7" file "music/CBLOOD7.ogg" }
music { id "CBLOOD8" file "music/CBLOOD8.ogg" }
music { id "CBLOOD9" file "music/CBLOOD9.ogg" }
music { id "CBLOOD10" file "music/CBLOOD10.ogg" }
music { id "UNHOLY" file "music/UNHOLY.ogg" }
music { id "PESTIS" file "music/PESTIS.ogg" }

It's just simple paths to the music, nothing that takes the control away from the user in an abusive way.
User avatar
sinisterseed
GZDoom RO Translator & Raze Tester
 
Joined: 05 Nov 2019
Twitch ID: sixhundredsixteen
Github ID: sinisterseed
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Music definitions do not work

Postby Gammli » Sat May 23, 2020 2:13 pm

The reason the music doesn't load is because Raze does not interpret the following as a relative path:
Code: Select allExpand view
music { id "intro" file "dukedc/music/tbss.ogg" }


and the fix really is as simple as changing it to the following:
Code: Select allExpand view
music { id "intro" file "./dukedc/music/tbss.ogg" }


Otherwise the file structure works fine.
Gammli
 
Joined: 02 Mar 2019

Re: Music definitions do not work

Postby Gez » Sat May 23, 2020 2:25 pm

Oh, that's it? Thanks.
Gez
 
 
 
Joined: 06 Jul 2007

Re: Music definitions do not work

Postby Graf Zahl » Sat May 23, 2020 2:32 pm

Thanks for that piece of info. I'll fix it ASAP.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Bugs

Who is online

Users browsing this forum: No registered users and 0 guests