[Closed] Random crash in softpoly

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Re: Random crash in softpoly

Postby dpJudas » Fri Apr 24, 2020 5:49 am

No matter how you slice it, an access violation for mMaterial.mMaterial->tex->shaderspeed can only be explained by two things: 1) access a pointer after deletion, 2) massive memory buffer overruns that messed up the pointer.

In any case, I'm in favor of waiting doing anything about it until graf's new branch gets merged in. There's no point in trying to do a workaround if the changes Graf did may have solved by the problem already, which it very well might. And even if it didn't, you'd have to do the fix twice then.
dpJudas
 
 
 
Joined: 28 May 2016

Re: Random crash in softpoly

Postby drfrag » Fri Apr 24, 2020 6:07 am

Yep seems that's the best course of action.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Random crash in softpoly

Postby Graf Zahl » Fri Apr 24, 2020 7:07 am

Can you test this on the texture rework branch?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Random crash in softpoly

Postby drfrag » Sat Apr 25, 2020 2:48 am

Done, seems it's gone now.
BTW what is the HAVE_SOFTPOLY option on linux for? AFAIK it's the minimal compile unit and it runs on software so it's always available, precisely i have a HAVE_OPENGL option to compile only with softpoly.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Random crash in softpoly

Postby Graf Zahl » Sat Apr 25, 2020 2:54 am

I need that to get the code into Raze and have it 100% identical with GZDoom. For the transition I must ensure that I can compile both engines off the exact same backend code base. Once the transition is complete the #define can be removed again
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Random crash in softpoly

Postby drfrag » Sat Apr 25, 2020 2:57 am

Okay.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Random crash in softpoly

Postby Graf Zahl » Sat Apr 25, 2020 6:10 am

I just had a crash with this code on my rework branch. But it wasn't mMaterial.mMaterial.tex that was bogus, but mMaterial.mMaterial itself.
On KDiZD Z1M1 I can reproduce it with almost 100% certainty after the initial wipe.
From the looks of it it tries to access the invalid material from the wipe texture. The problem looks to be PolyRenderState::Clear, being called from Set3DViewport which for unknown reason calls 'Apply'. But right after the wipe that's plain and simply an undefined operation because the currently set texture is no longer valid.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Random crash in softpoly

Postby drfrag » Sat Apr 25, 2020 6:34 am

I've just tried with the iwads for now, 10 launches in a row and now another 10.
What about reverting the old "fix"?
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Random crash in softpoly

Postby Graf Zahl » Sat Apr 25, 2020 6:54 am

I had no crashes with the IWADs, I had crashes with KDiZD. The IWADs do not seem to trigger the condition that causes the problem.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Random crash in softpoly

Postby Rachael » Sat Apr 25, 2020 6:58 am

drfrag wrote:What about reverting the old "fix"?

Short of prettying the code, the fix does not affect anything whatsoever and reverting it will not fix your problem.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Random crash in softpoly

Postby drfrag » Sat Apr 25, 2020 7:42 am

Just asking. It's not my problem but our problem.
No crash here with KDIZD 1.2 and g4.4pre-381-g70d30feb4. RelWithDebInfo v141 64 bit. But actually there's another crash if i exit the selection box without launching the game.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Random crash in softpoly

Postby drfrag » Tue Jun 30, 2020 5:35 am

Seems it's gone after the texture refactor.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Previous

Return to Closed Bugs

Who is online

Users browsing this forum: Yandex [Bot] and 1 guest