A_M_Refire Error

Discuss all aspects of editing for ZDoom.
Forum rules
Before asking on how to use a ZDoom feature, read the ZDoom wiki first. If you still don't understand how to use a feature, then ask here.

A_M_Refire Error

Postby Enjay » Sat Dec 10, 2016 6:15 pm

[Edit] Hmmm... the mod is complicated and there's lot's of stuff going on. Not sure if the following is right or not. [/edit]

With today's GZDoom build, if I run a mod that uses an actor derived from the scripted marines, I get the following error:

Code: Select allExpand view
Script error, "00BaseZipControlText.wad:actors/decplyr.txt" line 236:
Expected ',', got ')'.


The mod used to work and, as far as I can tell from the wiki ( A_M_Refire ) the following syntax is correct:

Code: Select allExpand view
PLAY A 0 A_M_Refire(1)


It's certainly how it appears in the DECORATE for the scripted marines in zdoom.pk3, but every time the above code is used, I get the error message. I know a lot has changed under the hood with ZScript and so on so I'm just checking whether this is an editing error or if it's a bug.
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: A_M_Refire Error

Postby Enjay » Sat Dec 10, 2016 6:55 pm

I notice that the zscript versions of the scripted marines have the following:
Code: Select allExpand view
PLAY A 0 A_M_Refire(1, "FistEnd");

Could GZDoom be expecting a state name even though this is being used in DECORATE rather than in ZScript?
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: A_M_Refire Error

Postby Blue Shadow » Sat Dec 10, 2016 8:07 pm

Yes, the function seems to have changed. Instead of jumping forwards to the next state, as wiki mentions, now you can choose where you want to jump by specifying a state label. Providing a state label is required.
User avatar
Blue Shadow
 
 
 
Joined: 14 Nov 2010
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: A_M_Refire Error

Postby Enjay » Sat Dec 10, 2016 8:09 pm

Should it be fixed to allow "no state name specified so default to old behaviour" or "if used in DECORATE rather than ZScript, allow no state name"? It seems to have the capability of breaking old mods as it currently stands.
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: A_M_Refire Error

Postby Ed the Bat » Sat Dec 10, 2016 8:48 pm

It certainly broke Lizard Squad. Though, even if I were to fix that, the erroneous use of "null" in SBARINFO (when it should have been "untranslated") leaves it broken still. I'm happy to put out a hotfix on LizardCommando's behalf, but I'll wait to hear if there's any rulings about this, engine-side.
User avatar
Ed the Bat
I'm tired. I want to go home.
 
Joined: 03 May 2012
Location: Maryland, US

Re: A_M_Refire Error

Postby Kinsie » Sun Dec 11, 2016 12:00 am

Definitely worth filing this as a bug. Old DECORATE code is supposed to still work as it did pre-ZScript.
User avatar
Kinsie
Dog Days
 
Joined: 22 Oct 2004
Location: MAP33
Discord: Find Me...
Twitch ID: thekinsie

Re: A_M_Refire Error

Postby Graf Zahl » Sun Dec 11, 2016 4:44 am

So much for the hope I could sanitize some code in a supposedly rarely used class... :(
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: A_M_Refire Error

Postby Ed the Bat » Sun Dec 11, 2016 12:59 pm

The erroneous use of "null" in SBARINFO is still something that will need to be fixed mod-side, though, right?
User avatar
Ed the Bat
I'm tired. I want to go home.
 
Joined: 03 May 2012
Location: Maryland, US

Re: A_M_Refire Error

Postby Graf Zahl » Sun Dec 11, 2016 1:16 pm

Can't say. I guess, yes.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Editing (Archive)

Who is online

Users browsing this forum: No registered users and 2 guests