Text colour incorrect at start of a line

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
Talon1024
 
 
Posts: 373
Joined: Mon Jun 27, 2016 7:26 pm
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support
Contact:

Text colour incorrect at start of a line

Post by Talon1024 »

Here's an example. The opening parenthesis before the URL should be gray, but it is orange. Only the URL should be orange.
User avatar
Marisa the Magician
Posts: 3886
Joined: Fri Feb 08, 2008 9:15 am
Preferred Pronouns: She/Her
Operating System Version (Optional): (btw I use) Arch
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia
Contact:

Re: Text colour incorrect at start of a line

Post by Marisa the Magician »

I can confirm this has been happening for a long time, seemingly arbitrarily, every time line breaking is involved. I just never figured a way to reproduce it consistently, though, so it's nice to see a proper report.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49053
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Text colour incorrect at start of a line

Post by Graf Zahl »

If this is about line breaking screwing up text colors, yes, this is ancient. However, due to the inevitable fact that some mods depend on it it could not be fixed.
For multiline text, each line needs to start with a color control code then.
User avatar
Marisa the Magician
Posts: 3886
Joined: Fri Feb 08, 2008 9:15 am
Preferred Pronouns: She/Her
Operating System Version (Optional): (btw I use) Arch
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia
Contact:

Re: Text colour incorrect at start of a line

Post by Marisa the Magician »

Mods depend on broken color when breaking lines?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49053
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Text colour incorrect at start of a line

Post by Graf Zahl »

Don't ask me, this was more than 10 years ago. Randi declined to fix it back then.
Talon1024
 
 
Posts: 373
Joined: Mon Jun 27, 2016 7:26 pm
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support
Contact:

Re: Text colour incorrect at start of a line

Post by Talon1024 »

Graf Zahl wrote:For multiline text, each line needs to start with a color control code then.
It's not exactly multi-line... It's one line of text, but it gets wrapped to 4 lines because of the SetHudSize call.
User avatar
Marisa the Magician
Posts: 3886
Joined: Fri Feb 08, 2008 9:15 am
Preferred Pronouns: She/Her
Operating System Version (Optional): (btw I use) Arch
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia
Contact:

Re: Text colour incorrect at start of a line

Post by Marisa the Magician »

Looking at V_BreakLines it does seem that it TRIES to preserve color escapes when splitting a line in half, but it doesn't always work, even though one quick look through the code tells me everything is fine, but maybe it goes deeper.
User avatar
AFADoomer
Posts: 1322
Joined: Tue Jul 15, 2003 4:18 pm
Contact:

Re: Text colour incorrect at start of a line

Post by AFADoomer »

I think we have narrowed down the cause of this bug...

V_BreakLines does not account for colors that are defined after the space that ends up being use to split the string into lines once the max width is hit...

So something nonsensical like this:
SetHudSize(640, 400, 1);
SetHUDWrapWidth(150);
HudMessage(s:"\cCThis is a test string\cR!!!!!!!!"; 0, 1, CR_UNTRANSLATED, 100.0, 100.0, 0, 1.0);

...would end up split between 'test' and 'string', but because the "\cR" would have already been parsed before the max width was hit (but after the last whitespace was set), the next line would start out colored dark red (R), despite still being supposed to be gray (C).

Simple map with this script included is attached.
Attachments
MAP01.wad
(1.91 KiB) Downloaded 48 times
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49053
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Text colour incorrect at start of a line

Post by Graf Zahl »

Yeah, this was rather dumb. Fixed
Post Reply

Return to “Closed Bugs [GZDoom]”