[Fixed] Heretic's status bar shadow gradients glitched

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Heretic's status bar shadow gradients glitched

Postby Rachael » Fri Nov 13, 2020 11:55 pm

Not sure when this broke, but it worked just fine in 4.4.2.

The shadow gradients on the status bar for Heretic are broken.


Close up:
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Heretic's status bar shadow gradients glitched

Postby Player701 » Sat Nov 14, 2020 2:43 am

It works fine in 4.5.0 as well. This is where it started. It has something to do with the DTA_LegacyRenderStyle parameter passed to DrawTexture. In previous versions it was not present at all, but now it appears to default to STYLE_Translucent and it doesn't seem like any other values are used there.
User avatar
Player701
 
 
 
Joined: 13 May 2009
Location: Russia
Discord: Player701#8214
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Heretic's status bar shadow gradients glitched

Postby Rachael » Sat Nov 14, 2020 7:28 am

It's always the biggest commits that always have the most likelihood of generating problems such as this, making fixes much more difficult.
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Heretic's status bar shadow gradients glitched

Postby Nash » Thu May 06, 2021 2:34 pm

This still persists as of the latest master commit...
User avatar
Nash
Twitter/Facebook/Youtube: nashmuhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Twitch ID: nashmuhandes
Github ID: nashmuhandes

Re: Heretic's status bar shadow gradients glitched

Postby Graf Zahl » Thu May 06, 2021 4:17 pm

Yeah, the sins of the past. Instead of supporting any render style I just hacked in a flag (DI_ALPHAMAPPED) which logically was forgotten when this was implemented properly much later. Obviously this flag needs to override the render style if it is set.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Heretic's status bar shadow gradients glitched

Postby Rachael » Fri May 07, 2021 1:42 am

Thank you for the hint. After digging around in 4.5.0's source I discovered what DI_ALPHAMAPPED did and made the proper adjustment to the status bar code.
https://github.com/coelckers/gzdoom/com ... a5379c11ee
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests