[Fixed] [4.5.0] Endoom crash

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[4.5.0] Endoom crash

Postby InsanityBringer » Sun Nov 08, 2020 9:41 pm

I have no idea if this is related to this, but when closing the ENDOOM dialog after closing GZDoom g4.5.0, I reliably get a crash. However, in order to trigger it, you need to start a map first. Once a map is loaded, you can quit GZDoom, and trying to close the ENDOOM screen will cause the crash.

Crash report and .ini in case settings are important are attached.

edit: mysteriously this has stopped happening under my current settings. One of those bugs, fuun..
You do not have the required permissions to view the files attached to this post.
User avatar
InsanityBringer
 
Joined: 05 Jul 2007
Location: opening the forbidden box
Discord: InsanityBringer#9908

Re: [4.5.0] Endoom crash

Postby InsanityBringer » Mon Nov 09, 2020 12:39 pm

I've experimented with this further, and it seems the crash only happens if you have only used the software renderer in a session. If you start with or switch to the hardware renderer at any point when the map is loaded, it won't crash.
User avatar
InsanityBringer
 
Joined: 05 Jul 2007
Location: opening the forbidden box
Discord: InsanityBringer#9908

Re: [4.5.0] Endoom crash

Postby Player701 » Mon Nov 09, 2020 2:18 pm

I could not reproduce the crash on my laptop. Will try on my desktop PC tomorrow. However, I discovered another issue with ENDOOM during testing.
User avatar
Player701
 
 
 
Joined: 13 May 2009
Location: Russia
Discord: Player701#8214
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [4.5.0] Endoom crash

Postby drfrag » Mon Nov 09, 2020 2:33 pm

I cannot reproduce it with the OpenGL backend.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: [4.5.0] Endoom crash

Postby InsanityBringer » Mon Nov 09, 2020 2:51 pm

Hmm, yeah, I guess it's a vulkan thing, since I basically always use vulkan. It doesn't happen on OpenGL here.
User avatar
InsanityBringer
 
Joined: 05 Jul 2007
Location: opening the forbidden box
Discord: InsanityBringer#9908

Re: [4.5.0] Endoom crash

Postby Graf Zahl » Mon May 17, 2021 5:07 am

It does not crash my current buuld and I can remember having done something about this alreeady.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [4.5.0] Endoom crash

Postby InsanityBringer » Mon May 31, 2021 8:51 am

I just tried it on the 4.6.0 release and it still seems to be crashing. Guessing then it's an AMD thing, whee. There's stuff in the vulkan validation output but I have no idea if any of it is going to affect this.

Probably not super useful due to that, but crash report attached just in case.
You do not have the required permissions to view the files attached to this post.
User avatar
InsanityBringer
 
Joined: 05 Jul 2007
Location: opening the forbidden box
Discord: InsanityBringer#9908

Re: [4.5.0] Endoom crash

Postby Zhs2 » Tue Jun 01, 2021 8:17 am

Can confirm the crash happens in 4.6.0 after exiting to ENDOOM and clicking to close in Vulkan with the software renderer. I have a RX 6700 XT, latest AMD drivers 21.5.2. Here's my crash report.
You do not have the required permissions to view the files attached to this post.
User avatar
Zhs2
Power of meh.
 
Joined: 07 Nov 2008
Location: Maryland, USA, but probably also in someone's mod somewhere
Operating System: Windows 10/8.1/8/201x 64-bit
Graphics Processor: ATI/AMD with Vulkan Support

Re: [4.5.0] Endoom crash

Postby Rachael » Tue Jun 01, 2021 9:00 am

It's not an AMD thing I managed to get it to crash on both AMD and NVidia.

Zhs's post gave some clue as to how to reproduce it effectively - it seems that the software renderer must be in use, you must quit from the menu to the endoom screen, and try to close the endoom screen with the big red X at the top of the window.

As far as I can tell, what happens is, it's calling the Vulkan destructors after Vulkan has already been destroyed. I don't really know how to fix this, other than nulling it out, but I don't really know what needs to be nulled.
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [4.5.0] Endoom crash

Postby Graf Zahl » Tue Aug 10, 2021 11:22 am

fixed.

The problem was that the software drawer wasn't taken down before the rest of the backend and got hung up on stale pointers.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest