[Fixed] ALLOWBOUNCEONACTORS and SpecialMissileHit issues

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

ALLOWBOUNCEONACTORS and SpecialMissileHit issues

Postby Marisa Kirisame » Thu Aug 06, 2020 1:54 pm

I couldn't do a more descriptive title, sorry.

I have an issue at the moment with a specific kind of bouncing missile in a mod, wherein it should bounce on shootable BUT not bleeding actors, and in the case of bleeding actors it should instead proceed normally and allow me to use SpecialMissileHit to handle custom ripping.

This, unfortunately, does not work. More often than not, the missiles simply die inside the actor unconditionally, even if I'd normally return 1 from SpecialMissileHit. I dug through the whole missile movement code to figure out what the issue is, and it seems to be in how and when P_BounceActor is called. Specifically, that it's called unconditionally, without a SpecialMissileHit check beforehand, and since it returns false because it "doesn't bounce" on those bleeding actors, it just explodes automatically. This is a problem.

So, what I'm getting at here is: There should be a call to SpecialMissileHit BEFORE this call to P_BounceActor in p_mobj.cpp line 2079.
User avatar
Marisa Kirisame
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: MarisaDOOM
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: ALLOWBOUNCEONACTORS and SpecialMissileHit issues

Postby Major Cooke » Wed Aug 12, 2020 6:45 pm

Bugfix PR, tested by Marisa.
User avatar
Major Cooke
QZDoom Maintenance Team
 
Joined: 28 Jan 2007

Re: ALLOWBOUNCEONACTORS and SpecialMissileHit issues

Postby Rachael » Fri Aug 14, 2020 12:02 am

I've merged the PR, in hopes that it does not break anything else.
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Debian-like Linux (Debian, Ubuntu, Mint, etc) 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests