DEH issue with Doom I / Ultimate Doom

[James Flasch]

The latest version of GZDoom seems to have a problem with displaying episode-end messages from DEH files in Doom I / Ultimate Doom. Load up the game with any Doom I megawad that has a DEH file and that file (EX. Invasion.wad and Invasion.deh), IDCLEV to any episode's level 8 and exit the level and the default episode-end message will appear instead of the one in the DEH file. The attached log file is from a test run in which I started GZDoom 4.4.2 with the above files, started a new game, IDLCEVed to E1M8 and clipped straight to the exit switch, hit it, and got the default end-episode text instead of that in the DEH file. Strangely, this bug does not affect Doom II.

invasion.log

(4.44 KiB) Downloaded 50 times

[drfrag]

This is the wad: https://www.doomworld.com/idgames/level ... ds/inva_19
First version affected by the bug is 4.0.0.

[_mental_]

With introduction of localization support, end episode texts are not identical to original messages. Double spaces were removed (ep. 1, 2, 4) and letter case was changed (ep. 4). I didn't check texts other than Ultimate Doom's.

[James Flasch]

_mental_ - the bug is that end-episode messages in DEH files don't override the default messages as they should.

[Graf Zahl]

Letter case should not matter, but the double spaces should probably be removed before comnparing contents.

[_mental_]

Fixed.

[3saster]

Fixed.

Almost! C6TEXT (the intermission screen before MAP32 of Doom 2) is missing a \n at the end in GZDoom, so this fix misses that one (either the language lump should be updated, or more should be added to this code fix). Of the 22 episode texts across Ultimate Doom, Doom 2, TNT, and Plutonia, this is the only non-matching one not covered by this fix (every other episode text is either already correct or fixed by this patch).

[_mental_]

Adding more conditions to code is bad idea in my opinion. If we really need sophisticated heuristics here, I would rather do a fuzzy comparison, via Levenshtein distance for example.

[Graf Zahl]

I generally agree, but making an exception for line feeds at the end may be necessary because these are somewhat problematic within a spreadsheet.

[Graf Zahl]

Added the missing line feed to C6TEXT.

[Yarn366]

It looks like your patch has broken C2TEXT (end of Doom II's MAP11), which still has double spaces. TXT_CHEATIDDQD, GOTBFG9000, GOTCHAINSAW, TXT_YOUFOOL, and TXT_YOUREDEAD also have double spaces and are presumably affected.

On a related note, GZDoom's STSTR_CLEV ("Changing Level...") has an extra newline, so DEH files don't replace it. (Then again, who actually does replace that string?)

[Player701]

Yeah, confirmed that C2TEXT is broken and is no longer replaced by DEHACKED patches. Maybe create another report for that?

[Graf Zahl]

Should all be fixed now