[4.4.0+] Model textures aren't affected by resizing

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Marisa the Magician
Posts: 3886
Joined: Fri Feb 08, 2008 9:15 am
Preferred Pronouns: She/Her
Operating System Version (Optional): (btw I use) Arch
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia
Contact:

[4.4.0+] Model textures aren't affected by resizing

Post by Marisa the Magician »

It appears that when texture resizing is enabled, it works for sprites, world textures, fonts, etc. according to their respective toggles, but models now never get affected.

If this gets fixed, I would prefer if it could also be toggleable like the rest, because this actually might be nice when combined with NormalNx scaling so I can sort of mix blocky world textures and sprites with trilinear model skins.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49067
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [4.4.0+] Model textures aren't affected by resizing

Post by Graf Zahl »

The question is: should they? With models it is impossible to tell if the texture's resolution is high enough or not and an upscale makes sense.
User avatar
Nash
 
 
Posts: 17439
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: [4.4.0+] Model textures aren't affected by resizing

Post by Nash »



Ahh looks like I ran into this too (using NormalNx at x4). There's a visual mismatch there between the texture on the tree model VS everything else in the world.

As for the question - I think they should, if only for unified behaviour. Whether it makes sense for the model or not is not the engine's responsiblity but the user.

But if options would be offered - I won't complain. As for where and how (on the MODELEDEF? Per texture in TEXTURES?), I have no preferences. Anywhere is fine.
User avatar
Apeirogon
Posts: 1605
Joined: Mon Jun 12, 2017 12:57 am

Re: [4.4.0+] Model textures aren't affected by resizing

Post by Apeirogon »

Graf Zahl wrote:should they?
No they dont.
In most, if not all, games models have several different textures with different detail level. Usually they used depending from the distance to the player camera, the closest model to the player the more detailed texture it uses, and vice versa. Sometimes they even used with low poly models for low quality textures. Optimization :trippy:
User avatar
Marisa the Magician
Posts: 3886
Joined: Fri Feb 08, 2008 9:15 am
Preferred Pronouns: She/Her
Operating System Version (Optional): (btw I use) Arch
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia
Contact:

Re: [4.4.0+] Model textures aren't affected by resizing

Post by Marisa the Magician »

I've even designed weapon models with textures MEANT to be pixelated, and NormalNx helps them look less jaggy without having to inflate the mod size by manually upscaling each texture, so there's that too.
User avatar
theleo_ua
Posts: 162
Joined: Sun Feb 07, 2016 11:38 am
Operating System Version (Optional): Windows 10
Graphics Processor: ATI/AMD with Vulkan/Metal Support
Location: Ukraine
Contact:

Re: [4.4.0+] Model textures aren't affected by resizing

Post by theleo_ua »

Nash wrote:Ahh looks like I ran into this too (using NormalNx at x4). There's a visual mismatch there between the texture on the tree model VS everything else in the world.

As for the question - I think they should, if only for unified behaviour. Whether it makes sense for the model or not is not the engine's responsiblity but the user.

But if options would be offered - I won't complain. As for where and how (on the MODELEDEF? Per texture in TEXTURES?), I have no preferences. Anywhere is fine.
I tried my heavy graphics mod with latest stable GZDoom (4.4.2 x64) and realized, that GZDoom takes 8GB of RAM (and this is not the limit - harder gameplay scenarios can consume more RAM)

I bet this is becauze XBRZ4x is applied to big hires textures/sprites, which don't require scaling

So personally I prefer next options:

1) HQ rescale all textures
values: on, off, mod defined

2) dont HQ rescale textures with more than X pixels count (on, off)
pixels count (integer)

3) dont HQ rescale textures with more than Y width (on, off)
width (integer)

4) dont HQ rescale textures with more than Z height (on, off)
height (integer)

5) dont HQ rescale textures, which are mentioned in texture black list file in the mod (on, off)

6) HQ rescale only the textures, which are mentioned in texture white list file in the mod (on, off)

By saying "textures" I mean textures, sprites, patches etc (at least which are located in HIRES folders/subfolders)
User avatar
Rachael
Posts: 13557
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: [4.4.0+] Model textures aren't affected by resizing

Post by Rachael »

User avatar
Marisa the Magician
Posts: 3886
Joined: Fri Feb 08, 2008 9:15 am
Preferred Pronouns: She/Her
Operating System Version (Optional): (btw I use) Arch
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia
Contact:

Re: [4.4.0+] Model textures aren't affected by resizing

Post by Marisa the Magician »

Thank you.
User avatar
Rachael
Posts: 13557
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: [4.4.0+] Model textures aren't affected by resizing

Post by Rachael »

You're welcome.
User avatar
theleo_ua
Posts: 162
Joined: Sun Feb 07, 2016 11:38 am
Operating System Version (Optional): Windows 10
Graphics Processor: ATI/AMD with Vulkan/Metal Support
Location: Ukraine
Contact:

Re: [4.4.0+] Model textures aren't affected by resizing

Post by theleo_ua »

Rachael wrote:fixed
Very nice commit, will test it even in devbuild (for now I using devbuilds even for streams because of memleaks in latest stable 4.4.2, so will use devbuilds until new stable ver will come)

Also, later I will post my message above as a suggestion in a new thread (but before this I will wait some time, for example your decisions on this viewtopic.php?f=2&t=69768&p=1164429#p1164464 thread, so maybe my suggestion is not relevant amymore)

The main idea of my coming suggestion is "make possibility to avoid HQ rescaling of any hires content (at least which located in hires folder/subfolders)". For now I use next workaround for this:

Step 1: turn off all HQ rescaling in options (filter = none, scaling factor = off (1x) )
Step 2: use XBRZ.exe software and rescale all lowres sprites (even from iwads and gzdoom.pk3) to xbrz6x png versions manually

Yes, I understand that this method is very very bad and dangerous (also maybe it can come with licence problems of using rescaled sprites from iwads) from some points of view, but for now I don't have another choices

P.S. Anyway, thank you (and other raze/gzdoom dev team) for your efforts and big amount of work for those nice ports, even with current versions, which are awesome even now! Very appreciated!
Post Reply

Return to “Closed Bugs [GZDoom]”