[4.2.1] JIT crash with "out vector2" as parameter.

[Guest]

Crash message: "JIT: sfunc->NumArgs != argsPos || regd > sfunc->NumRegD || regf > sfunc->NumRegF || rega > sfunc->NumRegA"

The message above always shows up in the example below. Before isolating the faulty code, the game simply froze and crashed with no message, unless I initialized the variable inside the method with, say, (0, 0).

Example: https://drive.google.com/open?id=1MzRdl ... XOWFuLTeZC

[phantombeta]

Some testing with an alternate example indicates this likely isn't the JIT's fault at all, and is probably just a case of the JIT being less forgiving of broken bytecode.

Code: Select all

class BEPlayerBase : DoomPlayer
{
	private void CheckCursorMovement(out vector2 CursorPosition, int maxWidth, int maxHeight)
	{
		Console.Printf ("%f, %f", CursorPosition.X, CursorPosition.Y);
	}

	vector2 SomeGridCoords;

	override void Tick()
	{
		int buttons = player.original_cmd.buttons;
		int oldbuttons = player.original_oldbuttons;

		if (buttons & BT_ATTACK)
		{
			CheckCursorMovement((50, 25), 5, 5);
		}

		Super.Tick();
	}
}

This alternate example causes the VM to crash with a Fatal Error window. Might include more details soon.

Edit: Further investigation shows that this is, indeed, (just as I thought) compiler fuckery:

More details soon maybe.

[dpJudas]

The check in the JIT is indeed one I added for sanity. It verifies that the input is what the code expects it to be. Either the input is invalid, or the code is based on assumptions that aren't always true. I assume its the former, but Graf should know for sure.

[phantombeta]

This is caused by a bug in the ZScript compiler Nevermind, I fucked up when debugging. Probably still a bug in the compiler, but not what I thought it was.

[Major Cooke]

The problem lies with structs, and vectors are such (for those who don't know).

Code: Select all

bool CheckLine(out Line ln)
{
	if (ln == null)
		return false;
	return true;
}

If you pass in a null Line struct, it'll destroy the game with the null check. But it doesn't crash if it's not in/out.

[phantombeta]

The problem lies with structs, and vectors are such (for those who don't know).
[...]
If you pass in a null Line struct, it'll destroy the game with the null check. But it doesn't crash if it's not in/out.

It's not really about being a struct, this is an issue that seems specific to vectors. The Line struct is also a native struct, which is always passed by pointer, not value, so it doesn't suffer from a lot of the problems "normal" structs do.
Also, please report that crash.

[phantombeta]

Fixed. This was caused by this bug, but vectors also had some hardcoded register offset code which had to be modified for this to actually work.