[4.1.2->4.2.1] Random hard crashes in maps that use fog

Moderator: GZDoom Developers

Forum rules
Please construct and post a simple demo whenever possible for all bug reports. Please provide links to everything.

If you can include a wad demonstrating the problem, please do so. Bug reports that include fully-constructed demos have a much better chance of being investigated in a timely manner than those that don't.

Please make a new topic for every bug. Don't combine multiple bugs into a single topic. Thanks!

[4.1.2->4.2.1] Random hard crashes in maps that use fog

Postby Jimmy » Tue Sep 03, 2019 1:18 pm

faithless-e2-crashreport.zip
(135.75 KiB) Downloaded 3 times


Happens on E2M6 of my current project.

The project pk3 I'm currently working on and its accompanying level layouts (all heavily WIP) can be found here: https://www.dropbox.com/s/o2mebikkf1ohg ... h.zip?dl=0
No other wads were loaded.

It's difficult to reproduce this crash terribly reliably, but it seems to only occur in maps that use "outsidefog" as defined in MAPINFO. Nine times out of ten, the crash will be a hard freeze and will exit to desktop without an error report at all. Luckily I was able to finally get one by flying around the map a whole bunch.

There are clearly a number of custom factors at play in the map in question, including weather effects, new monsters, new decorations, etc. but I am fairly certain I'm not mistaken in that the fog is the source of the issue. The same random crash seems to occur in E2M9 (if you de-comment the outsidefog parameter in MAPINFO.maps).
Last edited by Jimmy on Thu Sep 12, 2019 2:26 am, edited 1 time in total.
Jimmy
I picked a fine day to be lactose intolerant
 
 
 
Joined: 10 Apr 2006
Location: Perth, WA
Twitch ID: JimmySquared

Re: [4.1.2/4.2.0] Random hard crashes in maps that use fog

Postby _mental_ » Thu Sep 05, 2019 1:59 pm

The crash happened here. Does it crash with hardware renderer?
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [4.1.2/4.2.0] Random hard crashes in maps that use fog

Postby Jimmy » Fri Sep 06, 2019 11:38 am

Haven't gotten a crash in the hardware renderer yet, no. Software renderer was certainly heavily crash-prone for a while. Hard to say if the upgrade to 4.2.0 made the crashes rarer.
Jimmy
I picked a fine day to be lactose intolerant
 
 
 
Joined: 10 Apr 2006
Location: Perth, WA
Twitch ID: JimmySquared

Re: [4.1.2/4.2.0] Random hard crashes in maps that use fog

Postby Graf Zahl » Sat Sep 07, 2019 2:10 am

So, how could this be fixed? I'm sorry but this is code where I can't do much and I'd prefer to have this gone for the upcoming release.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [4.1.2/4.2.0] Random hard crashes in maps that use fog

Postby _mental_ » Sat Sep 07, 2019 2:42 am

Hard to say as it doesn't crash for me. Could be related to particular set of options though.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [4.1.2/4.2.0] Random hard crashes in maps that use fog

Postby Jimmy » Tue Sep 10, 2019 7:32 am

I can post my config if it helps.

https://www.dropbox.com/s/3o5jrbqy6j0u4 ... 9.ini?dl=1

I just got another crash on E2M9 (again, this map is intended to have fog but the MAPINFO parameter is commented out in the pk3). Sadly didn't get a report this time. Was still using 4.2.0. I'll check if it still happens in 4.2.1.

The crashes are definitely hard to reproduce, it can take maybe 10 minutes of roaming around.
Jimmy
I picked a fine day to be lactose intolerant
 
 
 
Joined: 10 Apr 2006
Location: Perth, WA
Twitch ID: JimmySquared

Re: [4.1.2/4.2.0] Random hard crashes in maps that use fog

Postby Jimmy » Thu Sep 12, 2019 2:25 am

Confirmed to still happen in 4.2.1.
Jimmy
I picked a fine day to be lactose intolerant
 
 
 
Joined: 10 Apr 2006
Location: Perth, WA
Twitch ID: JimmySquared

Re: [4.1.2->4.2.1] Random hard crashes in maps that use fog

Postby Graf Zahl » Thu Sep 12, 2019 2:31 am

Well, the software renderer wasn't touched between 4.2.0 and 4.2.1, so this is hardly surprising.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [4.1.2->4.2.1] Random hard crashes in maps that use fog

Postby Rachael » Thu Sep 12, 2019 5:22 am

The fog boundary crash is one of those vexing bugs that I haven't been able to fix for years, and it's not for lack of trying. I'm almost convinced that it's unfixable without completely rewriting the whole thing from scratch, and that's not something anyone has time for.

I've run the software renderer under a debugger several times, trying every conceivable fix I could think of, including bounds checking without writing such a horrific thing directly into the actual drawer, to no avail.

If someone finds a way to fix this damn thing, it'd make a ton of maps a lot more playable in the Software renderer, especially Stronghold's "Desert Storm" map, which suffers greatly from this bug. (And if you need a reliable test case for this bug, this is the best one I've found so far)

For whatever it's worth, it seems like the crash happens a lot more frequently when both fog and transparency are at play. Disabling the fog boundary certainly makes it crash less often, but I suspect that it's not the only thing causing issues, here.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: [4.1.2->4.2.1] Random hard crashes in maps that use fog

Postby drfrag » Thu Sep 12, 2019 5:48 am

I'd swear i moved this to Software Renderer Bugs. Is it okay to move viewtopic.php?f=35&t=62409 there too?
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

Re: [4.1.2->4.2.1] Random hard crashes in maps that use fog

Postby Rachael » Thu Sep 12, 2019 5:50 am

No, leave that where it is. If it's moved it'd have to be merged and it'd just confuse things because that topic is old.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: [4.1.2->4.2.1] Random hard crashes in maps that use fog

Postby Rachael » Fri Sep 13, 2019 9:01 am

Please try this build (or the next devbuild dated after this post) - it has this commit which seems to solve the STR12 problem for me. More extensive testing will be required, though.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle


Return to Software Renderer Bugs

Who is online

Users browsing this forum: No registered users and 0 guests