PathFollower doesnt fully finish the route

Is there something that doesn't work right in the latest GZDoom? Post about it here.

Moderator: GZDoom Developers

Forum rules
Please construct and post a simple demo whenever possible for all bug reports. Please provide links to everything.

If you can include a wad demonstrating the problem, please do so. Bug reports that include fully-constructed demos have a much better chance of being investigated in a timely manner than those that don't.

Please make a new topic for every bug. Don't combine multiple bugs into a single topic. Thanks!
Xabis
Posts: 63
Joined: Wed Mar 06, 2013 7:15 pm

PathFollower doesnt fully finish the route

Post by Xabis »

Hello,

Looks like PathFollower doesnt fully finish the final step at the end of the route, leaving it at the previous tick's interpolation position and angle.

I fixed this in a local override for my project, but thought the dev team should be made aware.

My fix:

Code: Select all

if (Time > 1.) {
	Time -= 1.;
	bJustStepped = true;
	PrevNode = CurrNode;
	CurrNode = CurrNode.Next;
	if (CurrNode != null)
		NewNode();
	if (CurrNode == null || CurrNode.Next == null || (Options & MP_LINEAR) == 0 && CurrNode.Next.Next == null) {
		//Do final interpolation to bring follower to its true end
		Time = 1.;
		CurrNode = PrevNode;
		Interpolate();
		CurrNode = null;
		Deactivate(self);
	}
}
_mental_
 
 
Posts: 3771
Joined: Sun Aug 07, 2011 4:32 am

Re: PathFollower doesnt fully finish the route

Post by _mental_ »

Could you post a sample to reproduce this bug?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 47983
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: PathFollower doesnt fully finish the route

Post by Graf Zahl »

Also, you can be dead certain that changing this after more than 15 years will break older maps.
User avatar
phantombeta
Posts: 1982
Joined: Thu May 02, 2013 1:27 am
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: PathFollower doesnt fully finish the route

Post by phantombeta »

Should this be closed as [Won't change] or [Can't fix]?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 47983
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: PathFollower doesnt fully finish the route

Post by Graf Zahl »

This needs to be thorougly tested with maps that use the feature. If the fix works, it should be added, but only if we are certain that nothing will break.

Return to “Bugs”