[Fixed] [??-g20b6395cf]Use after free with HUDMessages and DoomRPG

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[??-g20b6395cf]Use after free with HUDMessages and DoomRPG

Postby Edward-san » Wed Jun 19, 2019 4:08 pm

Yes, it's the same bug as here, as apparently not everything is fixed. I managed to make gzdoom crash again with a more recent build. See this report from the address sanitizer:

Spoiler:


How to reproduce this (happens by trial and error): load the same save file from the other bug report, then bind two keys to 'mdk' and 'summon cyberdemon', then press the key for 'mdk', then after a few moments (like half a second) press the key for 'summon cyberdemon', then again, after a few moments, 'mdk' and repeat. It will crash in a way or in another.
Edward-san
Mathematics is the language with which God has written the universe. (Galilei)
 
Joined: 17 Oct 2009

Re: [??-g20b6395cf]Use after free with HUDMessages and DoomR

Postby Graf Zahl » Fri Aug 09, 2019 1:15 am

I think I found it now. The detaching code was all fine and working, the problem was that the ticker loop for the messages didn't call it when a message had expired, but instead just unlinked the message, which in the middle of a garbage collection would cause all the same problems as before.

You really need a mod going overboard with HUD messages to trigger this, though.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: LedIris, TweetMeme [Bot], Yandex [Bot] and 0 guests