[Fixed] [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Postby Zergeant » Sat Apr 06, 2019 6:32 am

Using the pagename property as a string instead of number, it doesn't go to the next page properly, I've double-checked the names and it will either spit out an invalid node xx error in the console or it will go to a completely unrelated page. Number of pages have been cut down in order to debug easier.
Code: Select allExpand view
conversation
{
   // A hotheaded boy with a story to tell.
   actor = "Archvile";
   
   // Intro
   page
   {
      name = "Hothead";
      pagename = "Hello";
      dialog = "I got a burning feelin'!";
      choice
      {
         text = "Really now?";
         nextpage = "MyFeels";
      }
   }
   
   // Second page
   page
   {
      name = "Hothead";
      pagename = "MyFeels";
      dialog = "Yeah... My fiancee just left me...";
      choice
      {
         text = "Sorry to hear...";
         nextpage = "Japed";
      }
   }
   
   // Third page
   page
   {
      name = "Hothead";
      pagename = "Japed";
      dialog = "That's okay, we weren't doing too hot anyway! Har har har!";
      choice
      {
         text = "I ought to shoot you for that pun...";
         nextpage = "Hello";
      }
   }
}

This will result in an invalid node 11 not found error, running on g3.8pre-757-g0ed847b51.
Attachments
TutorialDialogue.wad
Demo map
(10.08 KiB) Downloaded 6 times
User avatar
Zergeant
 
Joined: 31 Aug 2010
Location: Sweden

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Postby Rachael » Thu Apr 25, 2019 1:25 pm

Huh. As far as I can recall, no one poked me about this, and this is a little important. I don't have time to look into it today - but I am bumping this as a reminder to myself to look into this.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Postby Nash » Thu Apr 25, 2019 4:16 pm

Sorry, I thought you'd already seen it. :) Yeah I was about to ask you about this issue recently but figured you had other things going on.
User avatar
Nash
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Github ID: nashmuhandes
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: nVidia with Vulkan support

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Postby Rachael » Wed May 22, 2019 2:13 pm

The point of failure seems to be here:

https://github.com/coelckers/gzdoom/blo ... f.cpp#L602

But I can't for the life of me figure out what's wrong with this statement. I sent Graf a PM to see if he has any idea but he might be busy. If anyone else has any clue what's happening here, I'm all ears.

This uses a hash table TArray.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Postby _mental_ » Sat May 25, 2019 9:20 am

There is nothing wrong with that line. The problem is in indexing of pages by names.
Numerical index refers the next page relatively to the root of conversation. Names are converted to absolute indices counted from zero.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Postby Rachael » Sat May 25, 2019 12:08 pm

Ugh. :|

Okay, I see.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Postby _mental_ » Sun May 26, 2019 7:47 am

Fixed in a54bc61.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Postby Rachael » Sun May 26, 2019 11:50 am

Thank you, _mental_. :)
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest