VM abort: player.txt line 374

Is there something that doesn't work right in the latest GZDoom? Post about it here.

Moderator: Developers

Forum rules
Please construct and post a simple demo whenever possible for all bug reports. Please provide links to everything.

If you can include a wad demonstrating the problem, please do so. Bug reports that include fully-constructed demos have a much better chance of being investigated in a timely manner than those that don't.

VM abort: player.txt line 374

Postby Major Cooke » Fri Nov 30, 2018 11:20 am

Code: Select allExpand view
virtual void CheckWeaponChange ()
{
   let player = self.player;
   if ((player.WeaponState & WF_DISABLESWITCH) || // <----------------------------------------------------------------Aborts here
      player.morphTics != 0)               // Morphed classes cannot change weapons.
   { // ...so throw away any pending weapon requests.
      player.PendingWeapon = WP_NOCHANGE;
   }

   // Put the weapon away if the player has a pending weapon or has died, and
   // we're at a place in the state sequence where dropping the weapon is okay.
   if ((player.PendingWeapon != WP_NOCHANGE || player.health <= 0) &&
      player.WeaponState & WF_WEAPONSWITCHOK)
   {
      player.DropWeapon();
   }
}


Specifically:

Code: Select allExpand view
if ((player.WeaponState & WF_DISABLESWITCH) ||


This can happen when morphing, it would appear.
User avatar
Major Cooke
The road to Hell is paved in the carrion she leaves behind.
 
Joined: 28 Jan 2007
Discord: Major Cooke#0846

Re: VM abort: player.txt line 374

Postby Graf Zahl » Fri Nov 30, 2018 12:14 pm

How can I reproduce this? You are particularly vague on that aspect.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: VM abort: player.txt line 374

Postby Major Cooke » Fri Nov 30, 2018 1:45 pm

Good question. Unfortunately, it's sporadic when playing D4D, so I cannot present a quick and easy demonstration.

Here's the resources and here's the bleeding edge.

Just put them in the same folder together and only load Doom4Doom-master.zip, it will auto-load the resources package for you.

I should also note I'm playing on maps like Dark Tartarus which makes extensive use of voodoo dolls.

I attempted to fix it myself by adding in at the top:

Code: Select allExpand view
if (!player || !player.mo)
   return;


I haven't encountered further aborts as of yet...
User avatar
Major Cooke
The road to Hell is paved in the carrion she leaves behind.
 
Joined: 28 Jan 2007
Discord: Major Cooke#0846

Re: VM abort: player.txt line 374

Postby Graf Zahl » Fri Nov 30, 2018 1:59 pm

Morphing and voodoo dolls are a match made in hell... :?
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Bugs

Who is online

Users browsing this forum: No registered users and 1 guest