[BUG] DamageFactor "Normal"

[Dinosaur_Nerd]

DamageFactor "Normal" is applied to all damage types, even custom damage types when applied.

below are video examples of this bug:

---

Test #1
Projectile

Code: Select all

Actor TestBullet: MonsterTracer
{
	Damage(50)
	DamageType "TestBullet"
	Seesound "LightDistantGunshot"
}

DamageFactors

Code: Select all

DamageFactors
DamageFactor "Normal", 0.5
DamageFactor "TestBullet", 0.5

HP loss
25 perhit


Test#2
Projectile

Code: Select all

Actor BruiserBall
{
	Damage(50)
	DamageType "HellFire"
}

DamageFactors

Code: Select all

DamageFactors
DamageFactor "Normal", 0.5
DamageFactor "TestBullet", 0.5

HP loss
25 perhit


Test#3
Projectile

Code: Select all

Actor TestBullet: MonsterTracer
{
	Damage(50)
	DamageType "TestBullet"
	Seesound "LightDistantGunshot"
}

DamageFactors

Code: Select all

DamageFactors
DamageFactor "TestBullet", 0.5

HP loss
25 per hit


Test#4
Projectile

Code: Select all

Actor BruiserBall
{
	Damage(50)
	DamageType "HellFire"
}

DamageFactors

Code: Select all

DamageFactors
DamageFactor "TestBullet", 0.5

HP loss
50 per hit

[Rachael]

As far as I know that is not a bug, but is actually an older intended way to apply DamageFactor to all damage types.

To have your intended effect I believe you need to specify "None".

[Zhs2]

As I was the one who recommended he report this, I believed the proper way to apply a DamageFactor to all types globally was to simply not specify a type at all, i.e. DamageFactor 1.5. The use of DamageFactor "Normal", multiplying any damage lacking a specific type, would be reinforced by the following example on two pages, the MAPINFO damage type definition page (Examples section) and [wiki=Custom_damage_types#Damagetype_declarations]the Custom damage types (in a deprecated section, but nonetheless is consistent with the first)[/wiki]:

Code: Select all

// In DECORATE:
Actor TakesMoreDamage
{
    DamageFactor "Normal", 1.5 // Takes extra damage for attacks that have no specific damage factor.
    // We have changed Drowning so that it ignores DamageFactor "Normal" by ReplaceFactor.
}