[3.5.1] warning for modder error appears only in GZD debug

[Matt]

To replicate:
Run this build of Hideous Destructor which contains the following function:

Code: Select all

	override double,int weaponbulk(){
		int mgg=weaponstatus[PISS_MAG];
		return 30+(mgg<0?0:(ENC_9MAG_LOADED+mgg*ENC_9_LOADED)); //this should also return an int but doesn't
	}

Expected: Error or warning that it's failing to return one of the values.

Actual: Lots of assertion errors that only appear in debug that someone who only uses release will never see.

[_mental_]

It's pretty easy to turn this into an error (or warning but as we all know they are usually ignored).

The problem is the fix will treat void function returning void as an error too. I.e. the following code will no longer work

Code: Select all

void func1()
{
}

void func2
{
    return func1();
}

Dear reader, if you think that the given code sample is artificial, you are wrong. Take a look at this line from GZDoom core script.
Of course it's a piece of cake to fix it for GZDoom. Although, I tested the change with D4D and HD, and they both failed to load thanks to usage of such constructs.

I found no good way to handle 'void returns void' thing so far.

[Graf Zahl]

They shouldn't be handled. Period. The mere fact that the core script is doing it just means that something was overlooked. But I guess if this needs to be handled, the check needs to be versioned then, i.e. only error out for script version 3.7 and up and print a warning if lower.

[Graf Zahl]

Pity that you analyzed it but didn't point to the problem spot. Now I have to do it all over again.

[_mental_]

Here is my attempt to fix this issue. It doesn't have version check though. I found it in a local branch and made PR for reference only.

[drfrag]

Now the engine won't start (version mismatch), i think the ZScript version needs to be bumped.

[Graf Zahl]

It starts for me. Are you sure you are completely up to date with everything?

Are these in your version.h?

#define VER_MAJOR 3
#define VER_MINOR 7
#define VER_REVISION 0

[drfrag]

I forgot it was bumped in master, now it's fixed.

[Major Cooke]

Dear reader, if you think that the given code sample is artificial, you are wrong. Take a look at this line from GZDoom core script.
Of course it's a piece of cake to fix it for GZDoom. Although, I tested the change with D4D and HD, and they both failed to load thanks to usage of such constructs.

I found no good way to handle 'void returns void' thing so far.

It's code like that which inspired me to use it, along with some other modders. Convenience and all: calls the function and terminate the current one. Alright, I'll go back through and fix it. So is it just a warning?

[_mental_]

It's an error with ZScript version 3.7 or above.

EDIT: Curiously enough 'void returns void' case is valid in C/C++ but not in C# or Java.

[Major Cooke]

Alright. Will fix it on my end then.