[3.5.0] Map Markers

Is there something that doesn't work right in the latest GZDoom? Post about it here.

Moderator: GZDoom Developers

Forum rules
Please construct and post a simple demo whenever possible for all bug reports. Please provide links to everything.

If you can include a wad demonstrating the problem, please do so. Bug reports that include fully-constructed demos have a much better chance of being investigated in a timely manner than those that don't.

Please make a new topic for every bug. Don't combine multiple bugs into a single topic. Thanks!

[3.5.0] Map Markers

Postby Enjay » Sat Aug 18, 2018 5:32 am

This has probably been the case for a long time and it may even be how it's meant to be but it seems a bit screwy to me.

Example map attached. There are two rows of map markers (thing 9040) and particle fountains. The markers+fountains on the left are all tid 1 and set to be active in the editor. The ones on the right are all tid 2 and set to be dormant.

Map markers should be able to be activated/deactivated to make them appear/disappear on the automap. However, I have come across two problems.

1) When placed in a map, initially markers are visible regardless of whether they are set to dormant or not.

Load the map and look at the automap. Both rows of markers are visible but (correctly) only the left fountains are active.

2) The activation/deactivation seems to be reversed.

Use the switch on the left. It runs a script to deactivate tid 1 and activate tid 2. The fountains respond appropriately - the left ones stop, the right ones start. However, when you check the automap, the left markers are visible and the right ones have disappeared.

Use the switch on the right. It runs a script to deactivate tid 2 and activate tid 1. Again, the fountains respond appropriately - the right ones stop and the left ones start again. On checking the automap though, you'll find the map markers on the left have now gone and the ones on the right are visible.


I think I set up everything correctly in the example map. However, I was using GZDB which I'm still not fully familiar with so I could have cocked up something, but I tried a similar map in DeePsea and got the same result.
Attachments
MapMarker01.zip
(1.6 KiB) Downloaded 30 times
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: [3.5.0] Mark Markers

Postby gwHero » Sat Aug 18, 2018 8:09 am

About the activation, deactivation:

if you look at the code in the gzdoom.pk3, the dormant flag is indeed set incorrectly:

Code: Select allExpand view
override void Activate (Actor activator)
   {
      bDormant = true;
   }

   override void Deactivate (Actor activator)
   {
      bDormant = false;
   }
   


This should be the other way around, so indeed a bug.
User avatar
gwHero
Be your own Siddhartha
 
Joined: 08 May 2017
Location: The Netherlands

Re: [3.5.0] Mark Markers

Postby _mental_ » Sat Aug 18, 2018 8:17 am

This seems to be true. The given behavior however was introduced with map markers themselves almost 12 years ago. Does anyone know some mod that actually uses map markers?
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [3.5.0] Map Markers

Postby Mikk- » Sat Aug 18, 2018 12:19 pm

The City of the Damned II & SoulCrusher are two that come to mind
User avatar
Mikk-
yooooooooooo
 
Joined: 30 Jun 2009
Location: Somewhere off Kanagawa
Discord: Mikk0451#3922

Re: [3.5.0] Map Markers

Postby Enjay » Sat Aug 18, 2018 1:52 pm

Do you know if they use them in a way where the activation/deactivation reversal would be a problem or are they just placed on the map?
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: [3.5.0] Map Markers

Postby _mental_ » Sun Aug 19, 2018 7:50 am

City of the Damned II (a.k.a Apocalypse) has 4 MoonMarker things derived from MapMarker class. They are just placed on the map and always active.
Two maps from Soulcrusher has 2 ShopMarker things each (derived from MapMarker too). Curiously enough things in both pairs are placed in the same location and differ only in dormant flags.
I think activation problem was here since map marker's inception. Strange that it was never reported before AFAIK.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [3.5.0] Map Markers

Postby Enjay » Sun Aug 19, 2018 11:30 am

I've used them before but only as statically placed things that were visible at map startup and for the duration of the game.

It wasn't until a couple of days ago when I decided to try switching them on and off as objectives were updating in a map that I noticed things weren't doing what I expected. Specifically, I was trying to turn off a map marker but every time I checked the automap, the marker was there even though I knew that the script to deactivate it was running. So I made the test map and it became more obvious what was going on.
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: [3.5.0] Map Markers

Postby Xaser » Sun Aug 19, 2018 3:31 pm

ZDCMP2's objective system uses them, but it opts to remove/create new markers rather than use activate/deactivate. May still be worth a test though.
User avatar
Xaser
anarchivist
 
 
 
Joined: 20 Jul 2003

Re: [3.5.0] Map Markers

Postby Kappes Buur » Sun Aug 19, 2018 4:45 pm

The map markers in Soulcrusher, for example in STADMIN, are quite interesting. When activated they indicate the objective
User avatar
Kappes Buur
 
 
 
Joined: 17 Jul 2003
Location: British Columbia Canada

Re: [3.5.0] Map Markers

Postby DabbingSquidward » Wed Aug 22, 2018 9:17 am

Rise of the Wool Ball & Dave Billing's SPAWN also use map markers.
User avatar
DabbingSquidward
 
Joined: 08 Nov 2017
Location: Germany


Return to Bugs

Who is online

Users browsing this forum: No registered users and 1 guest