Skybox rendered incorrectly on older machines

Is there something that doesn't work right in the latest GZDoom? Post about it here.

Moderator: GZDoom Developers

Forum rules
Please construct and post a simple demo whenever possible for all bug reports. Please provide links to everything.

If you can include a wad demonstrating the problem, please do so. Bug reports that include fully-constructed demos have a much better chance of being investigated in a timely manner than those that don't.

Please make a new topic for every bug. Don't combine multiple bugs into a single topic. Thanks!

Skybox rendered incorrectly on older machines

Postby gwHero » Mon May 28, 2018 2:42 pm

Hi,

today I tested my TC on 2 older laptops and to my surprise the skybox wasn't rendered correctly on those machines. Traced it down to a devbuild of end of April.

Screenshot from devbuild April 29 (ok)
Image

Screenshot from devbuild April 30 (wrong)
Image

Now the error occurs on older machines:
- dell laptop 6 years old with GL version 4.0.0 (windows 10)
- dell laptop 3 years old with GL version 4.2.0 (windows 8.1)

This does not occur on my own laptop with GL version 4.5.0 (windows 10), that's why I didn't notice this earlier.

As you can see, with the newer devbuilds the skybox is shown cubic with a dark black spot at the end.
I think this is pretty straightforward, but if it helps I could create a small demo wad.

(wad is played with gzdoom default video/display settings except for VSYNC ON, resolution 1366*768, fullscreen)
User avatar
gwHero
Be your own Siddhartha
 
Joined: 08 May 2017
Location: The Netherlands
Operating System: Windows 10/8.1/8/201x 64-bit
Graphics Processor: Intel with Vulkan Support

Re: Skybox rendered incorrectly on older machines

Postby Rachael » Mon May 28, 2018 11:56 pm

Can you post the extension string for the 4.0.0 and 4.2.0 please? As well as for the 4.5.0?

You can get that by running "gzdoom +logfile extensions.txt" on startup.

Additionally, we cannot debug a screenshot. You'll have to post a sample somewhere.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Skybox rendered incorrectly on older machines

Postby gwHero » Tue May 29, 2018 7:11 am

Hi,
included a zip with:

- demowad.pk3 - small wad to reproduce the error
- extensions.txt - logfile laptop GL 4.5 (runs fine)
- extensions2.txt - logfile laptop GL 4.2 (not ok)
- extensions3.txt - logfile laptop GL 4.0 (not ok)

Now I've been testing for hours, and it's even more complicated than I first thought.
- It never goes wrong on the GL 4.5 machine.
- It goes only wrong on the GL 4.2 & 4.0 machines when starting in FULLSCREEN. Switching fullscreen OFF solves it; even switching back ON it keeps running ok until you start GZDoom again in fullscreen...
- As mentioned before, the problem also only occurs with recent builds from April 30th and later, not the builds before that date.
You do not have the required permissions to view the files attached to this post.
User avatar
gwHero
Be your own Siddhartha
 
Joined: 08 May 2017
Location: The Netherlands
Operating System: Windows 10/8.1/8/201x 64-bit
Graphics Processor: Intel with Vulkan Support

Re: Skybox rendered incorrectly on older machines

Postby _mental_ » Tue May 29, 2018 7:17 am

Build dates are not very descriptive to be honest. It's much better to specify a version or commit.
In this case I guess it's about g3.4pre-345-g76ed80fe5 and later builds.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: Skybox rendered incorrectly on older machines

Postby gwHero » Tue May 29, 2018 9:35 am

_mental_ wrote:Build dates are not very descriptive to be honest. It's much better to specify a version or commit.
In this case I guess it's about g3.4pre-345-g76ed80fe5 and later builds.


Yeah I know, but the build was no longer on the list at dreamteam.org and on my laptop I keep them ordered by date. But I can confirm that the issue is with g3.4pre-345-g76ed80fe5 and later.
User avatar
gwHero
Be your own Siddhartha
 
Joined: 08 May 2017
Location: The Netherlands
Operating System: Windows 10/8.1/8/201x 64-bit
Graphics Processor: Intel with Vulkan Support

Re: Skybox rendered incorrectly on older machines

Postby Rachael » Tue May 29, 2018 9:58 am

There is a special system for retrieving older builds on drdteam, although it's not advertised (by intent). There's a developer mode switch on the skin control panel you can use to view hidden files. Much older builds still get pruned away, though.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Skybox rendered incorrectly on older machines

Postby gwHero » Tue May 29, 2018 10:57 am

Rachael wrote:There is a special system for retrieving older builds on drdteam, although it's not advertised (by intent). There's a developer mode switch on the skin control panel you can use to view hidden files. Much older builds still get pruned away, though.


Ah found it. Thanks, good to know.
User avatar
gwHero
Be your own Siddhartha
 
Joined: 08 May 2017
Location: The Netherlands
Operating System: Windows 10/8.1/8/201x 64-bit
Graphics Processor: Intel with Vulkan Support

Re: Skybox rendered incorrectly on older machines

Postby Graf Zahl » Sun Jun 03, 2018 12:41 am

I cannot reproduce this with my NVidia GPU and the attached demo mod, regardless of glversion setting. I'm afraid that someone else will have to do some testing to see at which revision exactly the behavior changed. There's 16 git commits between those 2 devbuilds.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Skybox rendered incorrectly on older machines

Postby gwHero » Sun Jun 03, 2018 4:45 am

Is there an easy way to get those revisions? (I'm a noob concerning GitHub) No problem to do the testing myself. Or are there some specific changes that are suspect so I could change it in the code on my machine? I still have the old laptop where this happens at my disposal.
User avatar
gwHero
Be your own Siddhartha
 
Joined: 08 May 2017
Location: The Netherlands
Operating System: Windows 10/8.1/8/201x 64-bit
Graphics Processor: Intel with Vulkan Support

Re: Skybox rendered incorrectly on older machines

Postby Graf Zahl » Sun Jun 03, 2018 5:14 am

As binaries, no. You'd have to compile them yourself.

If you already have a setup for compiling you need to check them out explicitly. The easiest way for that would be some GUI tool for Git.
If you cannot compile you'll need someone to provide you the builds.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Skybox rendered incorrectly on older machines

Postby gwHero » Sun Jun 03, 2018 5:32 am

Compiling is not a problem, I can create my own builds. I've used GitHub desktop once before on my old machine, so I'll invest some time in getting to figure out how it works - can't be too difficult I guess.
User avatar
gwHero
Be your own Siddhartha
 
Joined: 08 May 2017
Location: The Netherlands
Operating System: Windows 10/8.1/8/201x 64-bit
Graphics Processor: Intel with Vulkan Support

Re: Skybox rendered incorrectly on older machines

Postby Rachael » Sun Jun 03, 2018 6:25 am

They might be new enough that AppVeyor may still have builds. Check AppVeyor's artifacts for each of those revisions - I remember _mental_ explicitly set them up to save, but I have no idea AppVeyor's deletion policy (or if they are kept indefinitely).

Here's a list from AppVeyor for each of the revisions:

07586af6
93d8132b
76ed80fe
ebc1c574
c2ac9853
1345c8e7
4d72214f
852c42bb
6cd8b1b3
f91511bd
e9d84b88
76ec174f
06d20e13
9e6f3787
9350eee0
77b30161
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Skybox rendered incorrectly on older machines

Postby gwHero » Sun Jun 03, 2018 8:07 am

Yes, thank you, that really made things easier :)

With this I was able to narrow it down to the following builds:

Screenshot build 1345c8e7 (OK):
Image

Screenshot build c2ac9853 (WRONG):

Image

Note that the weapon sprite also is wrong here, which was corrected separately later.
User avatar
gwHero
Be your own Siddhartha
 
Joined: 08 May 2017
Location: The Netherlands
Operating System: Windows 10/8.1/8/201x 64-bit
Graphics Processor: Intel with Vulkan Support

Re: Skybox rendered incorrectly on older machines

Postby Graf Zahl » Sun Jun 03, 2018 9:53 am

There's still two uncompiled revisions in between those two...
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Skybox rendered incorrectly on older machines

Postby Graf Zahl » Sun Jun 03, 2018 10:00 am

I cannot reproduce it even with that particular revision. The odd thing is that between those two only 2D code was supposed to have changed.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Next

Return to Bugs

Who is online

Users browsing this forum: No registered users and 0 guests