[x64-g3.4pre-236-gc1ce6c90ca] Another Dynamic Lights Issue

Is there something that doesn't work right in the latest GZDoom? Post about it here.

Moderator: Developers

Forum rules
Please construct and post a simple demo whenever possible for all bug reports. Please provide links to everything.

If you can include a wad demonstrating the problem, please do so. Bug reports that include fully-constructed demos have a much better chance of being investigated in a timely manner than those that don't.

Re: [x64-g3.4pre-236-gc1ce6c90ca] Another Dynamic Lights Iss

Postby Xaser » Wed Apr 18, 2018 9:38 am

For people who have in-progress maps that rely on the broken method, what exactly are the steps required to preserve the look after the fix is made (e.g. the OP)?

[Before someone asks: I don't have any said maps myself. Just advocating.]
User avatar
Xaser
anarchivist
 
 
 
Joined: 20 Jul 2003

Re: [x64-g3.4pre-236-gc1ce6c90ca] Another Dynamic Lights Iss

Postby _mental_ » Wed Apr 18, 2018 10:33 am

Multiply size and secondarySize by 2/3. This should be done for all lights that have no attenuate property or it is set to non-zero value.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [x64-g3.4pre-236-gc1ce6c90ca] Another Dynamic Lights Iss

Postby Graf Zahl » Wed Apr 18, 2018 2:48 pm

To ease transition I'll add a LightSizeFactor that will apply to all following lights in a definition file. That'll mean you will only have to add one line at the top instead of changing every single light.

My reason for not keeping the bogus code is that it creates inconsistencies. It's only attached attenuated lights that are affected so it won't behave properly if the light was manipulated externally. The past has clearly shown that every bit of inconsistent behavior will inevitably cause problems and in the end still need a workaround so that it can be used in a reliable fashion.
Not again!
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [x64-g3.4pre-236-gc1ce6c90ca] Another Dynamic Lights Iss

Postby Xane123 » Wed Apr 18, 2018 5:17 pm

Not to add a potential second dynamic light bug, but is this related to this oddity where dynamic lights only light linedefs facing directly west or east but not diagonal or any other orientation?
inconsistent_lights.jpg

This was taken on commit 35596dbbc44713c9ab9521f0d044f1d9b0cb0397 and many commits are after this, so I don't know if this bug still exists, whether it is related to this or not.
User avatar
Xane123
Mary's Magical Adventure Developer
 
Joined: 24 Nov 2015
Location: Martinsburg, WV
Discord: Xane123#3770

Re: [x64-g3.4pre-236-gc1ce6c90ca] Another Dynamic Lights Iss

Postby Graf Zahl » Thu Apr 19, 2018 12:32 am

We cannot test and debug screenshots. If you want something checked, post a map or a link to a map.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [x64-g3.4pre-236-gc1ce6c90ca] Another Dynamic Lights Iss

Postby Nash » Tue Apr 24, 2018 2:11 pm

_mental_ wrote:Multiply size and secondarySize by 2/3. This should be done for all lights that have no attenuate property or it is set to non-zero value.


Care to clarify? Does that mean a size of 64 should be edited to be 38.4? (64 * (2 / 3))
User avatar
Nash
Nash Muhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia

Re: [x64-g3.4pre-236-gc1ce6c90ca] Another Dynamic Lights Iss

Postby _mental_ » Tue Apr 24, 2018 2:29 pm

Yes, something like that. Radii are integers internally though.

There is a better solution: 'lightsizefactor 0.667' on top of GLDEFS.
_mental_
 
 
 
Joined: 07 Aug 2011

Previous

Return to Bugs

Who is online

Users browsing this forum: No registered users and 2 guests