": not an instrument" on startup + timidity reverb crash

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
User avatar
Marisa the Magician
Posts: 3886
Joined: Fri Feb 08, 2008 9:15 am
Preferred Pronouns: She/Her
Operating System Version (Optional): (btw I use) Arch
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia
Contact:

": not an instrument" on startup + timidity reverb crash

Post by Marisa the Magician »

This rather helpful message from timidity pops up on startup now, and then gzdoom crashes.
Last edited by Marisa the Magician on Tue Mar 06, 2018 4:15 pm, edited 1 time in total.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Latest git master - ": not an instrument" on startup

Post by Graf Zahl »

I can't help you if you do not post the data causing the problem.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: Latest git master - ": not an instrument" on startup

Post by _mental_ »

Is it with or without 8145b52? Because it was said many times that latest is a vague term.
User avatar
Marisa the Magician
Posts: 3886
Joined: Fri Feb 08, 2008 9:15 am
Preferred Pronouns: She/Her
Operating System Version (Optional): (btw I use) Arch
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia
Contact:

Re: Latest git master - ": not an instrument" on startup

Post by Marisa the Magician »

@graf: This happens with anything that has midi music, including vanilla iwads, and happens regardless of the soundfont timidity is using, and it still happens even if timidity isn't the selected midi device. As soon as a midi has to play, it crashes.

@_mental_: Still happens without that commit, I'm going back a couple more right now to test.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Latest git master - ": not an instrument" on startup

Post by Graf Zahl »

In that case I still need a crash log. When I start GZDoom without any sound fonts on my Windows system it properly reverts to OPL.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: Latest git master - ": not an instrument" on startup

Post by _mental_ »

On Linux GZDoom crashed for me because soundfont loader didn't check directory with executable. And there are no soundfont installed in the system.
In the mentioned commit I added handling of this case as the last resort option.

Post a whole callstack please along with value of fluid_patchset CVAR. BTW do you have a soundfont in any of the following directories?

Code: Select all

$HOME/gzdoom/soundfonts
/usr/local/share/doom/soundfonts
/usr/local/share/games/doom/soundfonts
/usr/share/doom/soundfonts
/usr/share/games/doom/soundfonts
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Latest git master - ": not an instrument" on startup

Post by Graf Zahl »

Should $progdir/soundfonts be added to the search path list?
User avatar
Marisa the Magician
Posts: 3886
Joined: Fri Feb 08, 2008 9:15 am
Preferred Pronouns: She/Her
Operating System Version (Optional): (btw I use) Arch
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia
Contact:

Re: Latest git master - ": not an instrument" on startup

Post by Marisa the Magician »

The crash no longer happens from before the timidity branch merge.

Here's a crash log: http://ix.io/RTj

I have gzdoom.sf2 in /usr/share/gzdoom (this directory is assigned in cmake with -DSHARE_DIR)

The value of fluid_patchset is "/media/Data/Music/_Soundfonts/scc1t2.sf2" (it's a sc-55 soundfont I have).
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: Latest git master - ": not an instrument" on startup

Post by _mental_ »

What’s the version of FluidSynth? Versions between 1.1.7 and 1.1.9 crashes on some soundfonts. 1.1.6 works fine and the crash should be fixed in 1.1.10.
User avatar
Marisa the Magician
Posts: 3886
Joined: Fri Feb 08, 2008 9:15 am
Preferred Pronouns: She/Her
Operating System Version (Optional): (btw I use) Arch
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia
Contact:

Re: Latest git master - ": not an instrument" on startup

Post by Marisa the Magician »

It's 1.1.9, but I'm using timidity, not fluidsynth.

I've had it at that version since last month and the crashing didn't happen back then, anyway.
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Latest git master - ": not an instrument" on startup

Post by Rachael »

Just dropping a note here that while I was working on a project on Linux, I was getting the same crash as Marisa. I had to set GZDoom's midi synth to OPL emulation in order to get it to stop crashing.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Latest git master - ": not an instrument" on startup

Post by Graf Zahl »

Is this some GCC optimization issue again? Let's not forget that there's some pretty math heavy routines in there.
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Latest git master - ": not an instrument" on startup

Post by Rachael »

No, this was in Debug mode. Also, I was using Clang for development since it's a bit better with error messages when compiling code changes.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Latest git master - ": not an instrument" on startup

Post by Graf Zahl »

I hope this isn't a 64 bit issue. The Timidity code had looked like it wasn't ever compiled for 64 bit systems - and we all know that the memory layout on MSVC is not exactly the same as on GCC or Clang.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: Latest git master - ": not an instrument" on startup

Post by _mental_ »

Graf Zahl wrote:Should $progdir/soundfonts be added to the search path list?
I don't think so. On UNIX this can be useful during development only and without any other soundfont installed.
Explicit fallback path to default soundfont is better in this case.
Graf Zahl wrote:I hope this isn't a 64 bit issue. The Timidity code had looked like it wasn't ever compiled for 64 bit systems - and we all know that the memory layout on MSVC is not exactly the same as on GCC or Clang.
Works fine for me on macOS, 64-bit built with Clang. Tried without any config and with EAWPATS.

EDIT: Actually it crashes with timidity_chorus CVAR set to 1.
Post Reply

Return to “Closed Bugs [GZDoom]”