[Fixed] 3P (or more) multiplayer doesn't work in peer-to-peer.

Bugs that have been investigated and resolved somehow.

Moderator: Developers

3P (or more) multiplayer doesn't work in peer-to-peer.

Postby Somagu » Mon Jan 01, 2018 8:52 pm

(Using gzdoom-x64-g3.3pre-265-gbe81474 as linked on drdteam)

When three players try to connect using peer-to-peer mode, invariably one of them will meet with an unresponsive screen, while the other two players will be held up ingame waiting for the third player.

No mods are being loaded, and all players are able to connect to host and join to each other player if there are only two players.

Packet Server mode works fine.

Reverting to version 3.1.0a works under the above conditions with 3 or more players, but I am not thrilled with the idea of condoning the use of an insecure version of GZDoom (or any other program.)

[edit] Version 3.2.1 works, version 3.2.2 and beyond do not. Hope that helps.
User avatar
Somagu
 
Joined: 22 Nov 2013

Re: 3P (or more) multiplayer doesn't work in peer-to-peer.

Postby _mental_ » Tue Jan 02, 2018 6:25 am

I cannot reproduce this on one machine using three GZDoom running.
Could you please be more specific about that unresponsive screen? Is it just a black screen? Does something work in it (like menu or console) or should player just kill GZDoom process?
_mental_
 
 
 
Joined: 07 Aug 2011

Re: 3P (or more) multiplayer doesn't work in peer-to-peer.

Postby Somagu » Tue Jan 02, 2018 4:29 pm

The frozen player is unable to access the menu or console, the entire window becomes unresponsive, although the music begins playing first, and continues playing into the window being unresponsive, such as when a program stops responding in Windows, for example, and they are normally forced to kill the process. The other two players can look around and access the menu.

The host and the unresponsive window player can begin playing normally if the second responsive player leaves, but if the host leaves or the unresponsive player leaves, the session will remain frozen and unplayable.
User avatar
Somagu
 
Joined: 22 Nov 2013

Re: 3P (or more) multiplayer doesn't work in peer-to-peer.

Postby Rachael » Tue Jan 02, 2018 7:47 pm

It sounds like what's happening is with the peer-to-peer method the ports are not being opened and GZDoom is caught waiting for packets that never arrive from the other hosts.
User avatar
Rachael
QZDoom + Webmaster
 
Joined: 13 Jan 2004

Re: 3P (or more) multiplayer doesn't work in peer-to-peer.

Postby Marisa Kirisame » Fri Feb 09, 2018 6:48 am

I've tested up to 8 players on the same network, and there were no desyncs or "waiting for" happening. So I can confirm that this is definitely due to ports not being open.

You really have to make sure port 5029 is open for all players participating.
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa Kirisame#4689
Twitch ID: magusmarisa

Re: 3P (or more) multiplayer doesn't work in peer-to-peer.

Postby Somagu » Fri Feb 09, 2018 4:00 pm

I can personally confirm in all but one user's case (That's 3 out of the 4 other people besides myself that I had help me test this) that ports 5029 as well as the custom ports we attempted using (6667 and 27015) were all open, and we tested each user hosting each port. Again, they worked in an older version as mentioned in the first post, and it's fairly unlikely that they would have ever worked at all in peer-to-peer mode if the ports weren't open.

[edit]Nonetheless I'll check again later today so I can assuredly make myself look like an ass.
User avatar
Somagu
 
Joined: 22 Nov 2013

Re: 3P (or more) multiplayer doesn't work in peer-to-peer.

Postby Somagu » Fri Mar 16, 2018 2:50 pm

I realize it's a bit late for "later today" but I finally got around to testing this again with two other people I can be absolutely certain have their ports (but most particularly port 5029) forwarded. As per my earlier testing, version 3.2.1 worked, and the latest unstable revision released (GZDoom-g3.3pre-623-gd83456e9c) does not. Exact same issues as described earlier in the thread.

Cannot be replicated by a single user running multiple instances on one computer.
User avatar
Somagu
 
Joined: 22 Nov 2013

Re: 3P (or more) multiplayer doesn't work in peer-to-peer.

Postby Marisa Kirisame » Mon Mar 19, 2018 6:36 am

We're gonna need 3 people to bisect and check at what commit this started happening.

Edit: Since I have 3 computers I can try doing this on my own, wish me luck.

Edit #2: I need someone to do windows builds for me.

Edit #3: I can confirm at least that 3.2.1 works flawlessly and 3.2.2 is broken, so the bisect shouldn't need many steps.
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa Kirisame#4689
Twitch ID: magusmarisa

Re: 3P (or more) multiplayer doesn't work in peer-to-peer.

Postby Marisa Kirisame » Mon Mar 19, 2018 5:49 pm

After a lengthy session of bisecting, I've narrowed it down to commit 090943eaa49baa2a60ac89e2cb6ed8681f0301f6: "Fix freeze interpolation bug".

@dpJudas: I'm pointing all my fingers at you on this one :P
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa Kirisame#4689
Twitch ID: magusmarisa

Re: 3P (or more) multiplayer doesn't work in peer-to-peer.

Postby dpJudas » Mon Mar 19, 2018 7:58 pm

Should be fixed on master now.
dpJudas
 
 
 
Joined: 28 May 2016

Re: 3P (or more) multiplayer doesn't work in peer-to-peer.

Postby Marisa Kirisame » Tue Mar 20, 2018 2:47 am

We should celebrate with an 8-player match :P
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa Kirisame#4689
Twitch ID: magusmarisa


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest