Hello.
This commit https://github.com/coelckers/gzdoom/com ... 1d7a118044 unfortunately broke build on BSD (e.g. because of wordexp), was the previous feature wrong ?
Thanks for the good work otherwise.
Kindest regards.
Git commit broke build
Moderator: GZDoom Developers
Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
- Chris
- Posts: 2942
- Joined: Thu Jul 17, 2003 12:07 am
- Graphics Processor: ATI/AMD with Vulkan/Metal Support
Re: Git commit broke build
Prior to that patch, "quoted arguments" weren't honored. Unlike the Windows build they would get treated as two separate arguments, '"quoted' and 'arguments"', which breaks anything that needs a space (for example if you wanted to set timidity_extargs='-c "/path/to/soundfonts/my soundfont.cfg"').Phyllis Hirringhood wrote:This commit https://github.com/coelckers/gzdoom/com ... 1d7a118044 unfortunately broke build on BSD (e.g. because of wordexp), was the previous feature wrong ?
Does BSD not have wordexp? Both it and glob (which has been used to find the executable) are listed as being POSIX.1-2001, POSIX.1-2008.
Re: Git commit broke build
Not all unfortunately (wordexp is considered harmful and buggy to be worth implemented for some), ok I understand the reasoning a bit better though.
Re: Git commit broke build
I believe this was fixed in b871b18.