Git commit broke build

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
Guest

Git commit broke build

Post by Guest »

Hello.

This commit https://github.com/coelckers/gzdoom/com ... 1d7a118044 unfortunately broke build on BSD (e.g. because of wordexp), was the previous feature wrong ?

Thanks for the good work otherwise.
Kindest regards.
User avatar
Chris
Posts: 2940
Joined: Thu Jul 17, 2003 12:07 am
Graphics Processor: ATI/AMD with Vulkan/Metal Support

Re: Git commit broke build

Post by Chris »

Phyllis Hirringhood wrote:This commit https://github.com/coelckers/gzdoom/com ... 1d7a118044 unfortunately broke build on BSD (e.g. because of wordexp), was the previous feature wrong ?
Prior to that patch, "quoted arguments" weren't honored. Unlike the Windows build they would get treated as two separate arguments, '"quoted' and 'arguments"', which breaks anything that needs a space (for example if you wanted to set timidity_extargs='-c "/path/to/soundfonts/my soundfont.cfg"').

Does BSD not have wordexp? Both it and glob (which has been used to find the executable) are listed as being POSIX.1-2001, POSIX.1-2008.
Guest

Re: Git commit broke build

Post by Guest »

Not all unfortunately (wordexp is considered harmful and buggy to be worth implemented for some), ok I understand the reasoning a bit better though.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: Git commit broke build

Post by _mental_ »

I believe this was fixed in b871b18.
Post Reply

Return to “Closed Bugs [GZDoom]”