Mod CVARs are not grouped by mod

Is there something that doesn't work right in the latest GZDoom? Post about it here.

Moderator: GZDoom Developers

Forum rules
Please construct and post a simple demo whenever possible for all bug reports. Please provide links to everything.

If you can include a wad demonstrating the problem, please do so. Bug reports that include fully-constructed demos have a much better chance of being investigated in a timely manner than those that don't.

Please make a new topic for every bug. Don't combine multiple bugs into a single topic. Thanks!

Mod CVARs are not grouped by mod

Postby Kotti » Sun Jun 11, 2017 1:11 am

I noticed this while making some experiments with D4D.
CVARINFO has no facilities to group its content by mod, so if two mods happen to use the same CVAR name, it will actually be the same CVAR. Looking at the INI file seems to confirm it. It all gets dumped into either [Doom.Player.Mod] or [Doom.LocalServerInfo.Mod].
Kotti
 
Joined: 27 Dec 2016

Re: Mod CVARs are not grouped by mod

Postby Graf Zahl » Sun Jun 11, 2017 1:59 am

This just seems to be the tip of the iceberg. The entire config handling is poorly equipped to handle such broad gameplay mods in a robust fashion.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Mod CVARs are not grouped by mod

Postby Korell » Sun Jun 11, 2017 5:38 am

Personally, I use a separate ini file for each game/mod that I play with GZDoom, using a batch file with the necessary GZDoom parameters for each one. This way, any custom commands and settings that I use are kept for just the game/mod in question. Whilst I can understand why you might want to put all of the settings into a single ini file, I think it could lead to some very large ini files over time if someone plays a lot of different mods, and then if ever there are two or more different mods with the same name (or two different versions of the same mod that you switch between) then with a single ini file it could confuse which one the settings are for. If it were possible for GZDoom to create new ini files for each mod based on the primary gzdoom.ini file (say gzdoom-<username>-<modname>.ini then could that work around this issue?
User avatar
Korell
 
Joined: 28 May 2017

Re: Mod CVARs are not grouped by mod

Postby Graf Zahl » Sun Jun 11, 2017 9:07 am

I don't think it needs to go that far. Just replacing '.Mod' in the section names with the WAD name containing the CVARINFO lump would fix the problem.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Mod CVARs are not grouped by mod

Postby Caligari87 » Sun Jun 11, 2017 9:57 am

I'd be overjoyed if that could be made to cover the Weapon State keybinds too :D

8-)
User avatar
Caligari87
I'm just here for the community
User Accounts Assistant
 
Joined: 26 Feb 2004
Location: Salt Lake City, Utah, USA
Discord: Caligari87#3089

Re: Mod CVARs are not grouped by mod

Postby Graf Zahl » Sun Jun 11, 2017 10:23 am

Since you mention it: Keybinds not defined through KEYCONF are also a big problem because they are not mod specific.
The entire config handling needs a serious workover for mods that add new content through CVARINFO and KEYCONF.
ZDCMP2, for example tends to leave garbage behind in the global Doom namespace everytime it is played.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Mod CVARs are not grouped by mod

Postby Rachael » Sun Jun 11, 2017 10:37 am

Well with that in mind, provisions should be made for child ports doing that, as well. Zandronum defines a lot of CVars that never get used by GZDoom and GZDoom just tosses them into the "unknown" section when it finds them. Of course, this will have to be well commented in the source hopefully obviously enough so that they find it when they do their merge.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Mod CVARs are not grouped by mod

Postby Graf Zahl » Sun Jun 11, 2017 10:39 am

That's different.
ZDoom stores CVARINFO based variables in a special section - but there's only one - if two mods have the same named CVAR they interfere with each other.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Bugs

Who is online

Users browsing this forum: No registered users and 2 guests