Strife Dialogue NPCs Network issue

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Tapwave
Posts: 2096
Joined: Sat Aug 20, 2011 8:54 am
Preferred Pronouns: No Preference
Graphics Processor: nVidia with Vulkan support

Strife Dialogue NPCs Network issue

Post by Tapwave »

Too long for the title, but.
If you speak to a DIALOGUE-bound NPC in a netgame, and exit the dialogue box by clicking the dialogue exit choice rather than pressing esc, this NPC cannot be interacted with by anyone else but you.
User avatar
Nash
 
 
Posts: 17433
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: Strife Dialogue NPCs Network issue

Post by Nash »

An attempted fix, 5 years later. :D https://github.com/coelckers/gzdoom/pull/1312/files
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Strife Dialogue NPCs Network issue

Post by Graf Zahl »

Check line 691. It seems you missed one

player->ConversationFaceTalker = false;

that's no longer needed.
User avatar
Nash
 
 
Posts: 17433
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: Strife Dialogue NPCs Network issue

Post by Nash »

Woops. Fixed and force-pushed.
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Strife Dialogue NPCs Network issue

Post by Rachael »

Is there anything else that would make merging this right now bad?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Strife Dialogue NPCs Network issue

Post by Graf Zahl »

I don't think so.
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Strife Dialogue NPCs Network issue

Post by Rachael »

Alright I'll test it later on today and then merge it if I don't get any problems with it.
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Strife Dialogue NPCs Network issue

Post by Rachael »

Post Reply

Return to “Closed Bugs [GZDoom]”