Zip root folder detection fails if zip lacks folder entries

Is there something that doesn't work right in the latest GZDoom? Post about it here.

Moderators: Developers, ZDoom.org Team

Forum rules
Please, if you can include a wad demonstrating the problem, do so. Bug reports that include fully-constructed demos have a much better chance of being investigated in a timely manner than those that don't.

Zip root folder detection fails if zip lacks folder entries

Postby argv » Wed Sep 20, 2017 12:10 am

A while back, Graf taught GZDoom how to load a zip archive where all the resources are inside a single, top-level folder. After struggling to figure out why this Heretic mod wouldn't load, I discovered the cause.

As you know, most zip archivers place a separate entry in the zip's central directory for each folder, before the entries for the files in that folder. Because of this, FZipFile::Open assumes that, if there is a common prefix for every file in the archive, the name of the first entry will be that prefix.

That assumption doesn't always hold. In particular, for whatever reason, Bitbucket's zip generator does not generate separate zip entries for folders. Info-ZIP and 7-Zip don't emit any error messages about such archives when testing or extracting them, so this kind of zip structure seems to be generally recognized as valid. But because it isn't what FZipFile::Open expects, GZDoom doesn't load it correctly.

The attached file contains two zip archives, both containing a replacement TITLEPIC, to demonstrate the problem. “bugdemo-works.zip” has zip entries for the folders, and GZDoom loads it correctly. “bugdemo-broken.zip” has been stripped of folder entries, and while it extracts successfully with normal zip tools, GZDoom does not load it correctly.
Attachments
bugdemo.zip
Demonstration of the problem.
(5.12 KiB) Downloaded 5 times
argv
 
Joined: 30 Aug 2016

Return to Bugs

Who is online

Users browsing this forum: No registered users and 1 guest

cron