[Added] Request to deprecate/remove EventHandlers in GameInfo

Moderator: GZDoom Developers

Request to deprecate/remove EventHandlers in GameInfo

Postby Marisa the Magician » Sun Apr 17, 2022 3:37 am

The use of this property in the GameInfo block instead of AddEventHandlers has caused me enough frustration with hard to debug issues that people report when loading multiple mods. I don't think a footnote in the wiki about the dangers of its misuse is helping much in this case.
User avatar
Marisa the Magician
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa the Magician#1666
Twitch ID: MarisaDOOM
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Request to deprecate/remove EventHandlers in GameInfo

Postby Graf Zahl » Sun Apr 17, 2022 3:41 am

I'd silently change it to act the same as addEventHandlers, so that the old mods continue to work but don't remove previous handlers.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Request to deprecate/remove EventHandlers in GameInfo

Postby Marisa the Magician » Sun Apr 17, 2022 4:18 am

That is a reasonable change as well, thank you.
User avatar
Marisa the Magician
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa the Magician#1666
Twitch ID: MarisaDOOM
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Request to deprecate/remove EventHandlers in GameInfo

Postby m8f » Sun Apr 17, 2022 6:16 am

Oddly enough, this was No'ed before: viewtopic.php?f=18&t=71426

Anyway, great to have it finally done. Thanks!
User avatar
m8f
dreamer
 
 
 
Joined: 29 Dec 2017
Location: Siberia (UTC+7)
Discord: m8f#0629
Github ID: mmaulwurff
Operating System: Other Linux 64-bit


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 2 guests