[Redundant] Two things

Moderator: GZDoom Developers

Two things

Postby ace » Wed Jul 27, 2005 10:10 am

1: ClearLineSpecial WITH LineID, as opposed to

Code: Select allExpand view
SetLineSpecial(LineID, 0, 0, 0, 0, 0, 0);


2: ThrustThing WITH ThingID.

i.e., ClearlineSpecial(LineID); and ThrustThing(tid, angle, force);. Otherwise I can't specify which one I want to be cleared/thrusted. :?
User avatar
ace
Out of the woodwork...
 
Joined: 21 Jun 2005
Location: Just south of the True North

Postby Graf Zahl » Wed Jul 27, 2005 10:19 am

1. Why? It can already be done so any other means to do the same is redundant.
2. Already in. ThrustThing has been extended by one arg which passes the tid.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Postby ace » Wed Jul 27, 2005 10:31 am

1. I just find doing something like this

Code: Select allExpand view
ClearLineSpecial(14);
ClearLineSpecial(17);
ClearLineSpecial(19);
ClearLineSpecial(21);
ClearLineSpecial(28);


would be slightly more convenient.

2. Oh! Okay then. That would be added as a first arg, like in ThrustThingZ, right?
User avatar
ace
Out of the woodwork...
 
Joined: 21 Jun 2005
Location: Just south of the True North

Postby Graf Zahl » Wed Jul 27, 2005 10:41 am

No, for compatibility with the existing code it's the last arg.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Postby Costja » Wed Jul 27, 2005 10:45 am

ace, I think you always can write:
Code: Select allExpand view
function void ClearLineSpecial(int lineid) {
    SetLineSpecial(lineid, 0, 0, 0, 0, 0, 0);
}

And IMHO you can include it into one of zcommon "headers".
Costja
_PA_
 
Joined: 18 Oct 2004
Location: Russia, Moscow

Postby ace » Wed Jul 27, 2005 11:07 am

Graf Zahl wrote:No, for compatibility with the existing code it's the last arg.


Oh, okay then.

Costja wrote:ace, I think you always can write:
Code: Select allExpand view
function void ClearLineSpecial(int lineid) {
    SetLineSpecial(lineid, 0, 0, 0, 0, 0, 0);
}


And IMHO you can include it into one of zcommon "headers".


Ah right, didn't think of that. Thanks both! :)
User avatar
ace
Out of the woodwork...
 
Joined: 21 Jun 2005
Location: Just south of the True North


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest