[No] MAPINFO: EventHandlers -> an alias for AddEventHandlers

Moderator: GZDoom Developers

MAPINFO: EventHandlers -> an alias for AddEventHandlers

Postby m8f » Mon Feb 08, 2021 11:52 am

EventHandlers property clears all previously added event handlers. I see no reasonable use case for this behavior. If this is some kind of protection, it's easily broken by changing load order.

Up to this point I've seen two cases when this property breaks seemingly unrelated mods.

So, the suggestion: make it an alias for AddEventHandlers property. The cleaner solution would be to remove it, but it will break mods that use it.
User avatar
m8f
dreamer
 
 
 
Joined: 29 Dec 2017
Location: Siberia (UTC+7)
Discord: m8f#0629
Github ID: mmaulwurff
Operating System: Other Linux 64-bit

Re: MAPINFO: EventHandlers -> an alias for AddEventHandlers

Postby m8f » Tue Feb 09, 2021 9:10 am

This change is small enough, here is the PR.
User avatar
m8f
dreamer
 
 
 
Joined: 29 Dec 2017
Location: Siberia (UTC+7)
Discord: m8f#0629
Github ID: mmaulwurff
Operating System: Other Linux 64-bit

Re: MAPINFO: EventHandlers -> an alias for AddEventHandlers

Postby Graf Zahl » Tue Feb 09, 2021 9:13 am

m8f wrote: I see no reasonable use case for this behavior. If this is some kind of protection, it's easily broken by changing load order.


That has been said countless times, until that one mod came along that in fact needed the feature...
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: MAPINFO: EventHandlers -> an alias for AddEventHandlers

Postby Rachael » Tue Feb 09, 2021 9:27 am

This gets a pretty strong [No] from me. I really don't see any reason for this. Regardless of the OP's intent, you simply cannot assume the mod's design. If this is really such an issue, people should be educated to use AddEventHandlers unless it's absolutely necessary.
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Debian-like Linux (Debian, Ubuntu, Mint, etc) 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: MAPINFO: EventHandlers -> an alias for AddEventHandlers

Postby m8f » Tue Feb 09, 2021 9:30 am

Understood. No big deal, please tag accordingly.
User avatar
m8f
dreamer
 
 
 
Joined: 29 Dec 2017
Location: Siberia (UTC+7)
Discord: m8f#0629
Github ID: mmaulwurff
Operating System: Other Linux 64-bit

Re: MAPINFO: EventHandlers -> an alias for AddEventHandlers

Postby Rachael » Tue Feb 09, 2021 9:32 am

I'm going to wait for at least one other developer to respond, I do feel this still deserves more consideration, even though I've already stated my position on the issue, it's with what I feel is limited data at hand.
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Debian-like Linux (Debian, Ubuntu, Mint, etc) 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: MAPINFO: EventHandlers -> an alias for AddEventHandlers

Postby Graf Zahl » Tue Feb 09, 2021 10:59 am

Case closed I'd say.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: MAPINFO: EventHandlers -> an alias for AddEventHandlers

Postby Nash » Tue Feb 09, 2021 12:45 pm

Graf Zahl wrote:until that one mod came along that in fact needed the feature...


What mod is that?
User avatar
Nash
AKA Nash Muhandes! Twitter/Facebook/Youtube: nashmuhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Twitch ID: nashmuhandes
Github ID: nashmuhandes

Re: MAPINFO: EventHandlers -> an alias for AddEventHandlers

Postby Graf Zahl » Tue Feb 09, 2021 2:20 pm

the hypothetical mod that will inevitably be discovered - as it has been with every single change to the engine.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest