hiding par times

Moderator: GZDoom Developers

User avatar
m8f
 
 
Posts: 1422
Joined: Fri Dec 29, 2017 4:15 am
Location: Siberia (UTC+7)

hiding par times

Post by m8f »

Pull request

This CVAR controls if par time and suck time are displayed on intermission screen. True by default (original behavior).

This commit adds a new string to the menu, MISCMNU_WISHOWPARTIMES. In English it should be something like "Par time on summary screen".

Honestly, I'm not sure if this belongs to the engine at all. The engine is already oversaturated with options, but I found no way to mod around this barring replacing intermission screens.


This is more a personal nitpick than a widely useful feature. The reason behind this option is that the par time on the screen says how you "should" play a level, and it is irrelevant for modded play.
Last edited by m8f on Wed Nov 25, 2020 9:39 am, edited 2 times in total.
User avatar
Rachael
Admin
Posts: 13100
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her

Re: add wi_showpartimes cvar

Post by Rachael »

m8f wrote:The reason behind this option is that the par time on the screen says how you "should" play a level, and it is irrelevant for modded play.
Not to bike-shed or anything on this, but wouldn't it make more sense to make this mod controlled rather than using a CVAR?
User avatar
m8f
 
 
Posts: 1422
Joined: Fri Dec 29, 2017 4:15 am
Location: Siberia (UTC+7)

Re: add wi_showpartimes cvar

Post by m8f »

Like, how? Exposing to script how the intermission info (wbstartstruct_t) is filled up? Or making LevelLocals.partime not readonly so mods can set it to 0?

It's currently possible to replace intermissions screen by mods, but that would mean basically duplicating code and won't be compatible with custom intermissions.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 48355
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: add wi_showpartimes cvar

Post by Graf Zahl »

What do you need this for anyway? If it's for a mod, the proper way to add it would be a key in the gameinfo section of MAPINFO.
User avatar
Rachael
Admin
Posts: 13100
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her

Re: add wi_showpartimes cvar

Post by Rachael »

m8f wrote:Like, how?
Doing what Graf suggested, mainly. It could just be set to not show par times, and the appropriate ammendments would be made to the stat screen as needed to accomodate this.
User avatar
m8f
 
 
Posts: 1422
Joined: Fri Dec 29, 2017 4:15 am
Location: Siberia (UTC+7)

Re: add wi_showpartimes cvar

Post by m8f »

Done, force-pushed to the PR. Now instead of a CVAR this adds "hidepartimes" MAPINFO/GameInfo property which makes intermission screens hide par time and suck time.
False by default.

Example mod's mapinfo.txt that disables par times looks like this:

Code: Select all

gameinfo
{
  hidepartimes = true
}
(example mod is attached to the PR)

Return to “Closed Feature Suggestions [GZDoom]”