[Closed] Flat Sprite rotation fix

Moderator: GZDoom Developers

Flat Sprite rotation fix

Postby Major Cooke » Sun Aug 30, 2020 9:49 am

Pull Request (Currently marked as draft)

I was made aware some time ago that flat sprites did not have the same rotation code as models, which is supposedly the appropriate manner of doing so. This PR will bring it in line with the model rotation code and behave just like it. However, any mods reliant on the old behavior will inevitably be forced to update their code as it's no longer representing the current means of rotation.

As such I'm expecting to get flak for this. Probably a lot. :shock:

Attached is a demonstration file. Use "give z" in console and two sprites will spawn, featuring a sprite on a flat model plane (left) and a flat sprite (right).

The current implementation means users can avoid using quaternions or whatever else is there to keep the angle and pitch consistent, but the PR will ensure consistency so those who use models don't need a separate condition.

Personally, I'm torn directly down the middle if I want this or not, so I've marked the PR as draft so we can have a calm and civil discussion about it.
You do not have the required permissions to view the files attached to this post.
User avatar
Major Cooke
QZDoom Maintenance Team
 
Joined: 28 Jan 2007

Re: Flat Sprite rotation fix

Postby Graf Zahl » Sun Aug 30, 2020 10:04 am

I wish this feature could be shitcanned entirely.
One thing I definitely have on the table is to deprecate the entire flat/wallsprite functionality that's currently there and make these things useful by restricting them to what *walls* and *flats* actually are.

That said, this can only go in with a compatibility option.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Flat Sprite rotation fix

Postby Major Cooke » Sun Aug 30, 2020 10:05 am

On second thought, I'm closing this. This would break VisibleAngles/Pitch with it, which some mods rely upon to hide the backside. Adding a compatibility option with it would only increase the code bloat in it as well, and cache misses.

Those that want to use the actual proper rotation can use a flat model.
User avatar
Major Cooke
QZDoom Maintenance Team
 
Joined: 28 Jan 2007


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 0 guests