Spawn multi. items

Moderator: GZDoom Developers

User avatar
MatrixCL
Posts: 42
Joined: Tue Jul 07, 2020 2:53 am
Discord: Matrix#1375
Github ID: MaartenCL
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)
Location: Finland

Spawn multi. items

Post by MatrixCL »

There is the option to not spawn multiplayer weapons when playing in cooperative mode. I actually wonder why it is limited to just weapons and not all items. When we play Ultimate Doom in co-op, there is way more ammo and health packs than we need. (I'm quite sure those items were put there with deathmatch in mind, and the creators didn't bother to make a difference between deathmatch and co-op. But we can only guess.)

So my request is to either change that option to all items instead of just weapons, or add an option for that. Of course we need to consider the reason for having the option on just weapons instead of all items; there's more than just Doom and Doom II.

I imagine it's just changing or adding an if-statement somewhere and therefore not very complex, so also for this I'm willing to try and do it myself (in two weeks from now).
User avatar
MatrixCL
Posts: 42
Joined: Tue Jul 07, 2020 2:53 am
Discord: Matrix#1375
Github ID: MaartenCL
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)
Location: Finland

Re: Spawn multi. items

Post by MatrixCL »

I found the code that determines if and when multiplayer weapons are spawned and was able to simply change it so that multiplayer items in general are not spawned. I'll probably be able to make the full change.

But before I proceed, I need to know whether we change the existing option of spawning multi. weapons into spawning multi. items, whether we add an additional option, thus add another CVAR, or whether this is a bad idea in general (and I'll just have to use my own fork).
User avatar
drfrag
Vintage GZDoom Developer
Posts: 3110
Joined: Fri Apr 23, 2004 3:51 am
Discord: drfrag#3555
Github ID: drfrag666
Location: Spain

Re: Spawn multi. items

Post by drfrag »

Been there, done that. This commit in my master branch: "- Add the DF2_NO_COOP_THING_SPAWNDM flag to prevent spawning MP things in coop."
BTW search doesn't work for forks on GitHub. https://github.com/drfrag666/gzdoom
User avatar
MatrixCL
Posts: 42
Joined: Tue Jul 07, 2020 2:53 am
Discord: Matrix#1375
Github ID: MaartenCL
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)
Location: Finland

Re: Spawn multi. items

Post by MatrixCL »

Oh cool, thanks! So at least I can spare myself the effort. :D Will you make a pull request to get it in the next version?
User avatar
Rachael
Admin
Posts: 12895
Joined: Tue Jan 13, 2004 1:31 pm
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Preferred Pronouns: She/Her

Re: Spawn multi. items

Post by Rachael »

MatrixCL wrote:Oh cool, thanks! So at least I can spare myself the effort. :D Will you make a pull request to get it in the next version?
This would be the preferred method of getting it included, if anyone does happen to get this done.
User avatar
drfrag
Vintage GZDoom Developer
Posts: 3110
Joined: Fri Apr 23, 2004 3:51 am
Discord: drfrag#3555
Github ID: drfrag666
Location: Spain

Re: Spawn multi. items

Post by drfrag »

Actually i forgot i had added this. And i assume i tested it and it worked. :)
If there's interest i could do a PR later. You can test the DM flag with this devbuild: https://devbuilds.drdteam.org/lzdoom/lz ... a7b83c4.7z
And as always remember that SoftPoly is the default.
User avatar
MatrixCL
Posts: 42
Joined: Tue Jul 07, 2020 2:53 am
Discord: Matrix#1375
Github ID: MaartenCL
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)
Location: Finland

Re: Spawn multi. items

Post by MatrixCL »

I tested it and it works! This is LZDoom though. :-| I hope it will be in GZDoom as well then. I have no idea what SoftPoly is, by the way. :roll:
User avatar
drfrag
Vintage GZDoom Developer
Posts: 3110
Joined: Fri Apr 23, 2004 3:51 am
Discord: drfrag#3555
Github ID: drfrag666
Location: Spain

Re: Spawn multi. items

Post by drfrag »

I will do a PR and i'll backport it to the old LZDoom then. I don't think this is really important tough. Do you know there are also less monsters (mainly the Cyberdemons) in some maps right?
Softpoly is the default backend and it's software on D3D.
Edit: done the PR. https://github.com/coelckers/gzdoom/pull/1165
User avatar
Rachael
Admin
Posts: 12895
Joined: Tue Jan 13, 2004 1:31 pm
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Preferred Pronouns: She/Her

Re: Spawn multi. items

Post by Rachael »

Thank you for the PR. added

Return to “Closed Feature Suggestions”