Please change - Gibs != RealGibs

Moderator: GZDoom Developers

User avatar
Nash
 
 
Posts: 17282
Joined: Mon Oct 27, 2003 12:07 am
Twitch ID: nashmuhandes
Github ID: nashmuhandes
Location: Kuala Lumpur, Malaysia

Please change - Gibs != RealGibs

Post by Nash »

I have a really high-ress gib replacement sprite.

It looks fine when placed as a map decoration (scaled through DeHacked), but when a monster is crushed under a door, the engine spawns a different sprite called RealGibs which is unscaled and unmodifiable in any way - thus breaking any modifications I made through DeHacked.

These two objects should be the same...
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 47962
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Post by Graf Zahl »

Can't be changed. It would really mess up DEHACKED patches that change the gib actor if it was.
User avatar
Xaser
 
 
Posts: 10771
Joined: Sun Jul 20, 2003 12:15 pm

Post by Xaser »

What we really need is the ability to modify existing objects with DECORATE. That would allow you to change the RealGibs actor itself.
User avatar
BouncyTEM
Posts: 3805
Joined: Sun Aug 24, 2003 5:42 pm
Location: 2280 Lol Street: The Calamitous Carnival (formerly Senators Prison)

Post by BouncyTEM »

Xaser wrote:What we really need is the ability to modify existing objects with DECORATE. That would allow you to change the RealGibs actor itself.

I agree. If we were able to do this, Dehacked would OFFICIALLY be useless for GOOD.
User avatar
Cutmanmike
Posts: 11253
Joined: Mon Oct 06, 2003 3:41 pm
Discord: https://discord.gg/Whts7Bj
Operating System: Windows Vista/7/2008 64-bit
Location: United Kingdom

Post by Cutmanmike »

I agree, but I think graf had a reason why this cannot be done.
User avatar
randi
Site Admin
Posts: 7724
Joined: Wed Jul 09, 2003 10:30 pm

Post by randi »

The problem is that Doom did not spawn a gib actor when something was crushed. Instead, the crushed actor was set to the gib state. There may not be any Dehacked patches that took advantage of this behavior, but I prefer to play it safe and stay compatible.
Cptschrodinger
Posts: 380
Joined: Thu Oct 21, 2004 5:27 pm

Post by Cptschrodinger »

Well, Then can we define the gib state with decorate?
User avatar
Enjay
 
 
Posts: 26402
Joined: Tue Jul 15, 2003 4:58 pm
Location: Scotland

Post by Enjay »

randy wrote:The problem is that Doom did not spawn a gib actor when something was crushed. Instead, the crushed actor was set to the gib state. There may not be any Dehacked patches that took advantage of this behavior, but I prefer to play it safe and stay compatible.


Purely for the record, when this behaviour was changed to the current Zdoom one, it did minorly mess up the dehacked patch I was working on at the time. Irrelevant now, but I remember it did catch me "on the hop" at the time.
User avatar
Nash
 
 
Posts: 17282
Joined: Mon Oct 27, 2003 12:07 am
Twitch ID: nashmuhandes
Github ID: nashmuhandes
Location: Kuala Lumpur, Malaysia

Post by Nash »

Okay, I see that this thread has Randy's official NO labelled on it, but as someone said earlier; how about a gibbed/crushed state for the actor through DECORATE?
ant1991331
Posts: 598
Joined: Fri Jun 24, 2005 3:19 am
Location: Makin tracks with jetboots

Post by ant1991331 »

Xaser wrote:What we really need is the ability to modify existing objects with DECORATE. That would allow you to change the RealGibs actor itself.

although, i asked this before, and it would be great if you could....
User avatar
MartinHowe
Posts: 1958
Joined: Mon Aug 11, 2003 1:50 pm
Location: Waveney, United Kingdom

Post by MartinHowe »

cutmanmike wrote:I agree, but I think graf had a reason why this cannot be done.
Why not? Inheritance is handled by class names, not DoomEdNums. What one wants, more often than not, is a new actor to replace the original but with the same DoomEdNumber. This is not a strong as actually modifying the original actor, but is close enough that it surely deserves to be implementd?

Define a new actor inheriting from an old one and have a new decorate keyword something like this:

Code: Select all

ACTOR MyZombie : ZombieMan SAMEID
{
    obituary "%o was killed by a modified Zombie."
}


All this would do is suppress the warning about two things having the same DoomEdNum, surely that's a trivial matter to change? After all, the original ZombieMan can still be referenced by class name. As to changing the originals, what problems would this cause:

Code: Select all

MODIFY ZombieMan IMPLICIT
{
    obituary "%o was killed by a modified Zombie."
}


The IMPLICIT keyword would mean that changes were inherited whenever the game implicitly uses a ZombieMan for something. EXPLICIT would mean that the changes would only affect ZombieMen created or referenced explicitly by the mapper, for example by placing one by DoomEdNum in the editor or SpawnSpot() in a script.

In effect, ZDoom would need to store a copy of the original definition; however, that could be standard anyway. Each predefined THING could be defined as Default<ClassName> inside the system, with <ClassName> being defined by the game automatically as a no-change inheritance of the default version if nothing tries to change the default version of the THING. In this case, the "real" ZombieMan would be DefaultZombieMan and ZombieMan would automatically be created by the game if nobody attempted to modify Zombies.

The MODIFY, EXPLICIT and IMPLICIT keywords would only work on predefined THINGS. Note that the default version should NOT have a DoomEdNum as it would only be needed internally for use by the game. Indeed, although it would be possible to refer to the default item explicitly by class name (for example, in a script), should it even be allowed?

Discuss :)
User avatar
Nash
 
 
Posts: 17282
Joined: Mon Oct 27, 2003 12:07 am
Twitch ID: nashmuhandes
Github ID: nashmuhandes
Location: Kuala Lumpur, Malaysia

Post by Nash »

I fully agree with Martin's idea...
User avatar
wildweasel
Moderator Team Lead
Posts: 21361
Joined: Tue Jul 15, 2003 7:33 pm

Post by wildweasel »

MartinHowe, you have just showcased the old saying "Great minds think alike" - this is exactly what I was thinking.
User avatar
Xaser
 
 
Posts: 10771
Joined: Sun Jul 20, 2003 12:15 pm

Post by Xaser »

The ability to modify existing things will fix more problems than anything else I can think of right now. MartinHowe, you have summed up the whole thing perfectly, and I can't think of any reason why not to add this.
User avatar
Giest118
Posts: 2914
Joined: Fri Dec 05, 2003 11:02 pm

Post by Giest118 »

Bouncy wrote:Dehacked would OFFICIALLY be useless for GOOD.


Not quite.

It's still necessary if you want backwards compatibility, and it has the ability to change the player's max health.... (And yes, there are uses for that.)

Return to “Closed Feature Suggestions”