[Added] Fix intermission scaling

Moderator: GZDoom Developers

Re: Fix intermission scaling

Postby Rachael » Wed May 06, 2020 6:11 am

I've added screen border flats resizing, I do want to do the frame too but not sure how much work that will be.

I've also added customization - you can now put in a factor that determines how much the pixels will resize, relative to 320x200. You can also change the pixel aspect.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Fix intermission scaling

Postby Nash » Wed May 06, 2020 6:21 am

Glad to see my clueless rummaging in the source turned into a sophisticated and customizable feature. :) Great job, Rachael!
User avatar
Nash
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Github ID: nashmuhandes

Re: Fix intermission scaling

Postby Rachael » Wed May 06, 2020 9:00 am

Thank you. :)

Screen bevels are now also done.


User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Fix intermission scaling

Postby Nash » Wed May 06, 2020 9:16 am

Those look amazing! The visuals are SOOOOO much better now!
User avatar
Nash
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Github ID: nashmuhandes

Re: Fix intermission scaling

Postby Enjay » Wed May 06, 2020 9:46 am

Egad! I forgot how big those bevels were. :lol: Mind you, I don't really see them anyway.

Good work on this. As Graf said in the other thread, it's something that has lain untouched for 20+ years and it definitely needed doing. :yup:
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: Fix intermission scaling

Postby Rachael » Wed May 06, 2020 9:48 am

Thanks, again. :)

If anyone wants to try this out before the feature gets solidly set in stone, Github created an artifact that you can run: https://github.com/coelckers/gzdoom/sui ... ts/5759418 - install it on top of a dev build or GZDoom 4.3.3.

The relevant CVARs are thus:

Code: Select allExpand view
CVAR(Bool, inter_classic_scaling, true, CVAR_ARCHIVE)
- This is a switch to turn on/off intermission scaling
CVAR(Bool, ui_screenborder_classic_scaling, true, CVAR_ARCHIVE)
- This is a switch to turn on/off screen border scaling
CVAR(Float, classic_scaling_factor, 1.0, CVAR_ARCHIVE)
- This is a multiplier relative to 320x200. Increase it to make the scaling relative to a higher resolution.
CVAR(Float, classic_scaling_pixelaspect, 1.2, CVAR_ARCHIVE)
- This is a multiplier for the pixel aspect ratio. Set to 1.2 for the default (stretched like 320x200), set to 1.0 to make it square.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Fix intermission scaling

Postby AFADoomer » Wed May 06, 2020 10:24 am

Very nice! Will there be any consideration for mod-side control? I can imagine someone has created a high-resolution frame image that will now look horrible and pixelated with the new defaults...

EDIT: Is that build you linked based off of the texture rework branch? If so, I may have a bug to report with shader compilation.
User avatar
AFADoomer
 
Joined: 15 Jul 2003

Re: Fix intermission scaling

Postby Rachael » Wed May 06, 2020 2:22 pm

Yes, it's based on the texture rework.

This could be redone for an older code base like LZDoom but it would have to be done manually.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Fix intermission scaling

Postby Scuba Steve » Wed May 06, 2020 4:17 pm

Good god, that looks so much better.
Scuba Steve
 
Joined: 28 Mar 2004

Re: Fix intermission scaling

Postby Rachael » Thu May 07, 2020 12:19 am

Thank you, again. :)

I've now put the finishing touches on the branch, it should be ready for merge as soon as texture_rework is.

Graf - would it be more convenient for me to simply merge my work into texture_rework, itself?
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Fix intermission scaling

Postby Graf Zahl » Thu May 07, 2020 1:36 am

Sure.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Fix intermission scaling

Postby Redneckerz » Thu May 07, 2020 2:41 am

This is really the kind of feature you never knew was missed or even needed but now that its here, it looks sublime.

Once more a great showcase that details can have a dramatic impact on the result. Well done Rachael, that's definitely a selling point for GZDoom. :)
User avatar
Redneckerz
To it's ports i may have seen
Spotlight Team
 
Joined: 25 Nov 2019
Discord: Redneckerz#8399
Operating System: Windows Vista/7/2008 64-bit
Graphics Processor: nVidia (Legacy GZDoom)

Re: Fix intermission scaling

Postby Rachael » Thu May 07, 2020 2:48 am

Done.

Thank you, Red. :)
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Fix intermission scaling

Postby Rachael » Sat May 09, 2020 4:16 am

Closing as added.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Fix intermission scaling

Postby Scuba Steve » Mon May 18, 2020 10:45 am

Rachael, how can I test Doom with this enabled? I thought it would be in the latest SVN build... but I can't find if I still have to enable it through a cvar.
Scuba Steve
 
Joined: 28 Mar 2004

PreviousNext

Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 2 guests