A_StartSound default channel to CHAN_BODY
Moderator: GZDoom Developers
- Marisa the Magician
- Posts: 3886
- Joined: Fri Feb 08, 2008 9:15 am
- Preferred Pronouns: She/Her
- Operating System Version (Optional): (btw I use) Arch
- Graphics Processor: nVidia with Vulkan support
- Location: Vigo, Galicia
- Contact:
A_StartSound default channel to CHAN_BODY
To be honest this is mainly just a super-tiny change so it's easier to migrate lots of code from the old function to this one, unless there is some specific reason why the channel parameter shouldn't have the same default value as A_PlaySound.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49067
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: A_StartSound default channel to CHAN_BODY
None really, I wanted to take off the default from the sound name, this one must have happened when splitting up the parameter.
But there's another thing about A_StartSound: It has two boolean parameters. Now is still time to fold them into the flags to give the function a cleaner interface.
Or would that complicate your migration?
But there's another thing about A_StartSound: It has two boolean parameters. Now is still time to fold them into the flags to give the function a cleaner interface.
Or would that complicate your migration?
- Marisa the Magician
- Posts: 3886
- Joined: Fri Feb 08, 2008 9:15 am
- Preferred Pronouns: She/Her
- Operating System Version (Optional): (btw I use) Arch
- Graphics Processor: nVidia with Vulkan support
- Location: Vigo, Galicia
- Contact:
Re: A_StartSound default channel to CHAN_BODY
oh if they can be made flags that'd be nice, cleaner code.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49067
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: A_StartSound default channel to CHAN_BODY
I'll see to it before doing a new release. So be careful with that function.
- Marisa the Magician
- Posts: 3886
- Joined: Fri Feb 08, 2008 9:15 am
- Preferred Pronouns: She/Her
- Operating System Version (Optional): (btw I use) Arch
- Graphics Processor: nVidia with Vulkan support
- Location: Vigo, Galicia
- Contact:
Re: A_StartSound default channel to CHAN_BODY
It's fine, I'm not going to release any of this until there's a new gzdoom version.