[Added] A_StartSound default channel to CHAN_BODY

Moderator: GZDoom Developers

A_StartSound default channel to CHAN_BODY

Postby Marisa Kirisame » Mon Dec 30, 2019 4:03 am

To be honest this is mainly just a super-tiny change so it's easier to migrate lots of code from the old function to this one, unless there is some specific reason why the channel parameter shouldn't have the same default value as A_PlaySound.
User avatar
Marisa Kirisame
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: A_StartSound default channel to CHAN_BODY

Postby Graf Zahl » Mon Dec 30, 2019 4:25 am

None really, I wanted to take off the default from the sound name, this one must have happened when splitting up the parameter.
But there's another thing about A_StartSound: It has two boolean parameters. Now is still time to fold them into the flags to give the function a cleaner interface.
Or would that complicate your migration?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: A_StartSound default channel to CHAN_BODY

Postby Marisa Kirisame » Tue Dec 31, 2019 2:41 am

oh if they can be made flags that'd be nice, cleaner code.
User avatar
Marisa Kirisame
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: A_StartSound default channel to CHAN_BODY

Postby Graf Zahl » Tue Dec 31, 2019 2:50 am

I'll see to it before doing a new release. So be careful with that function. ;)
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: A_StartSound default channel to CHAN_BODY

Postby Marisa Kirisame » Tue Dec 31, 2019 6:03 am

It's fine, I'm not going to release any of this until there's a new gzdoom version.
User avatar
Marisa Kirisame
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 2 guests