[Added] Some way for sector skies to avoid being affected by SSAO

Moderator: GZDoom Developers

Re: Some way for sector skies to avoid being affected by SSA

Postby Rachael » Wed Dec 30, 2020 9:11 am

Well then, a consensus needs to be reached and whatever that may be, the PR will need to be adjusted to match.
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Debian-like Linux (Debian, Ubuntu, Mint, etc) 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Some way for sector skies to avoid being affected by SSA

Postby Nash » Wed Dec 30, 2020 9:22 am

I thought generally the way it goes with GZDoom feature enhancements is always "make sure old stuff always look the same way it did, newer stuff has to be opt in by modders themselves".
User avatar
Nash
AKA Nash Muhandes! Twitter/Facebook/Youtube: nashmuhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Twitch ID: nashmuhandes
Github ID: nashmuhandes

Re: Some way for sector skies to avoid being affected by SSA

Postby Graf Zahl » Wed Dec 30, 2020 9:26 am

I don't care about AO so you'll have to make up your minds without me. :P
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Some way for sector skies to avoid being affected by SSA

Postby Rachael » Wed Dec 30, 2020 9:37 am

Graf Zahl wrote:I don't care about AO so you'll have to make up your minds without me. :P

Then to spare any arguments I'll do an arbitration.

I'm going to take on the PR myself, and finish it, it's going to be default allowing SSAO, but, it needs an option both to enable it and disable it per-map (oops, this was there already, my mistake). The defaultmap or gamedefaults block can be used to set it for multiple maps at once.
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Debian-like Linux (Debian, Ubuntu, Mint, etc) 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Some way for sector skies to avoid being affected by SSA

Postby Enjay » Wed Dec 30, 2020 10:27 am

Nash wrote:I thought generally the way it goes with GZDoom feature enhancements is always "make sure old stuff always look the same way it did, newer stuff has to be opt in by modders themselves".

This, however, is a weird one. If the map was made pre-SSAO then it might have a skybox that doesn't look good with SSAO. So, that would normally dictate that the default should be SSAO = off in skyboxes. However, SSAO has been around long enough that people have made skyboxes expecting it.

So either option is going to "break" something that already exists. ;)

Honestly, even though I personally would prefer SSAO to be on in skyboxes by default, I actually think that it would be better to default to off. Why? Two reasons:

1) The older maps that were not designed with SSAO in mind are probably more numerous.

2) Ultimately, SSAO being off is less "harmful" than being on. A player might notice something and think "hang on, those buildings/rocks/cliffs in the background look a bit different to the ones that I can walk up to" if the player has SSAO enabled but it isn't present in the skybox. However, everyone is going to notice the huge black lines across the sky that happen when a skybox is set up like the ones in BoA. (Although, it's worth pointing out that the first issue in this reason will potentially occur in BoA if the skyboxes do not have SSAO because the rest of the architecture in the box will also not have SSAO.)


Now, if there was also a way to disable SSAO on a texture by texture/surface by surface basis, I really would be happy. That would mean that little light alcoves etc don't become dimmed to almost looking like they are not bright at all despite having LITE5 on each surface and being set to 255 brightness. But I realise that's a whole different problem. :P
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: Some way for sector skies to avoid being affected by SSA

Postby Tormentor667 » Wed Dec 30, 2020 11:08 am

Nash wrote:Why not make it the other way around? Opt in. Surely Torm can spare the 2 minutes to edit BoA's MAPINFO to disable SSAO in BoA's skyboxes... ;)

Exactly. I think we can keep the default behaviour as it was (SSAO in skyboxes activated), and I can simply add appropriate lines to the MAPINFO that disables SSAO in the BoA skyboxes, that's just fine and a really good reason compared to the crazy stuff that I must have done without that.

So I wonder, what do I have to add to the MAPINFO entries to activate that feature?
User avatar
Tormentor667
needs more detail
 
Joined: 16 Jul 2003
Location: Germany

Re: Some way for sector skies to avoid being affected by SSA

Postby Blue Shadow » Wed Dec 30, 2020 12:24 pm

Tormentor667 wrote:So I wonder, what do I have to add to the MAPINFO entries to activate that feature?

Add disableskyboxao to the maps for which you want it disabled.
User avatar
Blue Shadow
 
Joined: 14 Nov 2010
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: Some way for sector skies to avoid being affected by SSA

Postby Chris » Wed Dec 30, 2020 12:26 pm

Enjay wrote:Now, if there was also a way to disable SSAO on a texture by texture/surface by surface basis, I really would be happy. That would mean that little light alcoves etc don't become dimmed to almost looking like they are not bright at all despite having LITE5 on each surface and being set to 255 brightness. But I realise that's a whole different problem. :P

Doesn't PBR include an AO map that allows doing just this, specifying which parts of the texture can receive AO and which parts shouldn't? Or does GZDoom not implement that part of the pipeline?
User avatar
Chris
 
Joined: 17 Jul 2003

Re: Some way for sector skies to avoid being affected by SSA

Postby Enjay » Wed Dec 30, 2020 12:30 pm

Honestly, I don't know. I haven't messed seriously with PBR materials. They're a bit of a dark art to me so far. If the AO thing is in, it would be worth me investigating though.
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: Some way for sector skies to avoid being affected by SSA

Postby Tormentor667 » Wed Dec 30, 2020 12:36 pm

Blue Shadow wrote:
Tormentor667 wrote:So I wonder, what do I have to add to the MAPINFO entries to activate that feature?

Add disableskyboxao to the maps for which you want it disabled.

Thanks kindly, I will just do that - and thanks to anyone involved in this new feature!
User avatar
Tormentor667
needs more detail
 
Joined: 16 Jul 2003
Location: Germany

Re: Some way for sector skies to avoid being affected by SSA

Postby Tormentor667 » Wed Dec 30, 2020 12:42 pm

Update
Added it and tried it with today's dev-build of GZDoom, didn't work unfortunately:
Code: Select allExpand view
map C1M1 lookup "C1M1"   //Tormentor667
{
   levelnum = 1
   music = "NOMUSIC"
   cluster = 1

   // Force SSAO being disabled in skyboxes
   disableskyboxao
}

Anything wrong with it or was I just too quick and it hasn't been added to the svn devbuild yet?
User avatar
Tormentor667
needs more detail
 
Joined: 16 Jul 2003
Location: Germany

Re: Some way for sector skies to avoid being affected by SSA

Postby Enjay » Wed Dec 30, 2020 1:25 pm

Tormentor667 wrote:Anything wrong with it or was I just too quick and it hasn't been added to the svn devbuild yet?


From Github: "madame-rachelle - Modified commit from @OrdinaryMagician #1261 df4f41f 3 hours ago Git stats"

Image

;)
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: Some way for sector skies to avoid being affected by SSA

Postby Tormentor667 » Wed Dec 30, 2020 2:02 pm

User avatar
Tormentor667
needs more detail
 
Joined: 16 Jul 2003
Location: Germany

Re: Some way for sector skies to avoid being affected by SSA

Postby _mental_ » Wed Dec 30, 2020 2:20 pm

If you need this feature ASAP, grab Visual Studio 64-bit Release build artifact from this page. You should copy all .dll files from existing build in order to run it.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: Some way for sector skies to avoid being affected by SSA

Postby Marisa Kirisame » Wed Dec 30, 2020 3:51 pm

Oh, so in the end it was inverted. Welp.
User avatar
Marisa Kirisame
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: MarisaDOOM
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

PreviousNext

Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 0 guests