[Added] Pitch tuning in A_PlaySound/A_PlaySoundEX

Moderator: GZDoom Developers

Re: Sound Pitch Setting/Adjusting

Postby Graf Zahl » Wed Jul 24, 2019 2:07 am

This will be merged once Chris has made a review. I cannot judge if it is ok.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Pitch tuning in A_PlaySound/A_PlaySoundEX

Postby Rachael » Wed Jul 24, 2019 9:32 am

@Cooke: I merged your pull request thread. There's really no need to make a separate thread.

If you think Graf isn't going to notice, give him some time and see if he does, and then you cna post a reminder in the dev forum.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: Pitch tuning in A_PlaySound/A_PlaySoundEX

Postby Major Cooke » Wed Jul 24, 2019 9:48 am

Understood. Anyway I'm working with Chris on this now.
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007

Re: Pitch tuning in A_PlaySound/A_PlaySoundEX

Postby Rachael » Wed Jul 24, 2019 9:59 am

Oh also obviously - if you do make a pull request, make sure to remind us in your post to please move it to the code submissions section. ;) Moderators can do it too, so reporting it is fine.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: Pitch tuning in A_PlaySound/A_PlaySoundEX

Postby Major Cooke » Wed Jul 24, 2019 11:27 am

Alright.

@Graf: Chris has completed his work. And I've squashed it down into one commit so it's clean.
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007

Previous

Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest