[Added w/ changes] Version Mismatch text change

Moderator: GZDoom Developers

Version Mismatch text change

Postby Major Cooke » Sun Jun 30, 2019 1:34 pm

Pull Request

Because I keep getting the same question over and over again with my mods:

Many people wrote:What's this <x> expected and only <y> supported? I have <x> though!


I know that won't change anything in the short term, but as time goes on and new versions come out, that should hopefully fade off...
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007

Re: Version Mismatch text change

Postby drfrag » Sun Jun 30, 2019 1:59 pm

AFAIK ZScript and engine versions don't need to match. Besides i think you put them backwards.
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

Re: Version Mismatch text change

Postby Major Cooke » Sun Jun 30, 2019 6:15 pm

ZScript and GZDoom engine versions have been set to match for a while now. Also fixed.
Last edited by Major Cooke on Sun Jun 30, 2019 6:27 pm, edited 1 time in total.
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007

Re: Version Mismatch text change

Postby phantombeta » Sun Jun 30, 2019 6:26 pm

Major Cooke wrote:ZScript and GZDoom engine versions have been set to match for a while now. Also amusingly, it's been backwards for a while it seems.

That's not backwards. The mod expects 4.0.0 or higher, while the version of GZDoom is 3.5.1. Your PR, meanwhile, is actually backwards. It'd print
Code: Select allExpand view
Version mismatch. GZDoom 4.0.0 is incompatible with at least one file. Version 3.5.1 or later is required.

Which is obviously wrong.
User avatar
phantombeta
In the meadow of sinful thoughts, every flower's a perfect one
 
Joined: 02 May 2013
Location: The United Soviet Socialist Dictatorship of Hueland
Discord: phantombeta#2461
Twitch ID: phantombeta_
Github ID: Doom2fan
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: nVidia with Vulkan support

Re: Version Mismatch text change

Postby Major Cooke » Sun Jun 30, 2019 6:32 pm

Sadly I didn't finish the edit until after you did. At any rate it's all fixed.
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007

Re: Version Mismatch text change

Postby Rachael » Sun Jun 30, 2019 8:23 pm

drfrag wrote:AFAIK ZScript and engine versions don't need to match. Besides i think you put them backwards.

This is correct.

Major Cooke wrote:ZScript and GZDoom engine versions have been set to match for a while now.

Irrelevant. It's talking about the ZScript version, not the GZDoom version.

This PR basically creates an inherent misnomer, even if the ZScript version happened to match the GZDoom version all this time. It does not take into account child ports, which do not follow GZDoom's versioning scheme.

So yeah - this is not mergeable as-is.

Please rephrase it accordingly.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Graphics Processor: nVidia with Vulkan support

Re: Version Mismatch text change

Postby Rachael » Sun Jun 30, 2019 9:15 pm

I added this but with major changes in this commit.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Graphics Processor: nVidia with Vulkan support

Re: Version Mismatch text change

Postby Major Cooke » Sun Jun 30, 2019 9:19 pm

That's plenty good for me.
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 4 guests