[No] Use of "Pickup:" state in pickup-only items (i.e Armour)

Moderator: GZDoom Developers

Use of "Pickup:" state in pickup-only items (i.e Armour)

Postby XLightningStormL » Sun Dec 09, 2018 9:51 pm

Essentially the use of the Pickup actor state in AAPU items which typically include armours and powerups.

This system for example can be used to grant inventory items on pickup, so if picking up a Green Armour also gives me a seperate inventory item which when detected by a zscript script enables me to read its codex entry (a-la metadoom codex)
User avatar
XLightningStormL
DUSK Wiki Master
 
Joined: 09 May 2016
Discord: XLightningStormL#7461
Twitch ID: XLightmingStormL

Re: Use of "Pickup:" state in pickup-only items (i.e Armour)

Postby Graf Zahl » Mon Dec 10, 2018 2:34 am

The Pickup state is a relic from old DECORATE and no longer needed with ZScript.The entire CzustomInventory functionality is essentially deprecated by now. Don't expect any work to be done on this.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Use of "Pickup:" state in pickup-only items (i.e Armour)

Postby Matt » Mon Dec 10, 2018 3:55 am

Here is the ZScript that is now responsible for the CI pickup state behaviour. It calls CallStateChain first before trying the more normal means of picking things up.

EDIT: Except that CallStateChain is a native code that is unique to CustomInventory. What would be the ZS equivalent of this?

EDIT: Given CallStateChain is still hard-coded to do everything in one tic I take it it's not actually capable of doing anything that a direct TryPickup override can't do better...
User avatar
Matt
Putting the XD into *xdeath since 2007
 
 
 
Joined: 04 Jan 2004
Location: Gotham City SAR, Wyld-Lands of the Lotus People, Dominionist PetroConfederacy of Saudi Canadia

Re: Use of "Pickup:" state in pickup-only items (i.e Armour)

Postby Graf Zahl » Mon Dec 10, 2018 5:41 am

Matt wrote:Given CallStateChain is still hard-coded to do everything in one tic[/url] I take it it's not actually capable of doing anything that a direct TryPickup override can't do better...



Correct. That's why I consider the feature deprecated. It was nice to have when nothing better existed, but there is absolutely no point to expand on it anymore.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: Google [Bot] and 1 guest