[PULL REQUEST] Export FBoundingBox to ZScript

Moderator: GZDoom Developers

User avatar
drfrag
Vintage GZDoom Developer
Posts: 3141
Joined: Fri Apr 23, 2004 3:51 am
Location: Spain
Contact:

Re: [PULL REQUEST] Export FBoundingBox to ZScript

Post by drfrag »

Rachael wrote:and it's not known or likely to cause any other issues
That's precisely the point here, oops i've reverted it anyway. :P
I've noticed myself that the previous "solution" was a bit shitty and now i've added a FDrawInfo* parameter to GLPortal::End.
I don't even know what outer_di is but hey if it works it works. :D
https://github.com/drfrag666/gzdoom/com ... 9ac12ce215

I've noticed that LZDoom is also affected by this shit, there was a similar problem in 3.3.2 and seems something i cherry-picked has made it come back.
User avatar
phantombeta
Posts: 2084
Joined: Thu May 02, 2013 1:27 am
Operating System Version (Optional): Windows 10
Graphics Processor: nVidia with Vulkan support
Location: Brazil

Re: [PULL REQUEST] Export FBoundingBox to ZScript

Post by phantombeta »

Just to be sure, are there any issues with this PR?
I'd also like to know if this is really the proper way to do this - I feel like FBoundingBox itself should be exported so it's more useful for future scriptification of actors, but I can't simply do it, since everything creates and destructs it manually.
User avatar
phantombeta
Posts: 2084
Joined: Thu May 02, 2013 1:27 am
Operating System Version (Optional): Windows 10
Graphics Processor: nVidia with Vulkan support
Location: Brazil

Re: [PULL REQUEST] Export FBoundingBox to ZScript

Post by phantombeta »

I've given up on this PR due to some issues, so this can be closed.
User avatar
phantombeta
Posts: 2084
Joined: Thu May 02, 2013 1:27 am
Operating System Version (Optional): Windows 10
Graphics Processor: nVidia with Vulkan support
Location: Brazil

Re: [PULL REQUEST] Export FBoundingBox to ZScript

Post by phantombeta »

It seems this thread was left open. I've closed the PR a while ago, so this should be moved to Closed Feature Suggestions. (Maybe labelled something like just "Closed")
Post Reply

Return to “Closed Feature Suggestions [GZDoom]”