[Added] IsPointInMap - Void Testing Solution

Moderator: Developers

IsPointInMap - Void Testing Solution

Postby Major Cooke » Wed Nov 07, 2018 3:09 pm

Pull Request

Big thanks to dpJudas and Gutawer for helping me with this.

Finally, now you can test and see if a vector is inside the map or in the void. See the example below.
Attachments
test.pk3
Prints a message every second: "in map" or "in void" based on if inside level geometry. Noclip outside the map to test.
(470 Bytes) Downloaded 4 times
User avatar
Major Cooke
The road to Hell is paved in the carrion she leaves behind.
 
Joined: 28 Jan 2007
Discord: Major Cooke#0846

Re: IsPointInMap - Void Testing Solution

Postby Rachael » Wed Nov 07, 2018 3:18 pm

Saved me the trouble of (eventually) getting around to it.
User avatar
Rachael
QZDoom + Webmaster
 
Joined: 13 Jan 2004

Re: IsPointInMap - Void Testing Solution

Postby Graf Zahl » Wed Nov 07, 2018 3:50 pm

Why is this using an internal function of the node builder?
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: IsPointInMap - Void Testing Solution

Postby Major Cooke » Wed Nov 07, 2018 4:14 pm

I didn't know how to use the other versions of the function properly since they involved nodes.
User avatar
Major Cooke
The road to Hell is paved in the carrion she leaves behind.
 
Joined: 28 Jan 2007
Discord: Major Cooke#0846

Re: IsPointInMap - Void Testing Solution

Postby Graf Zahl » Wed Nov 07, 2018 4:26 pm

The main issue here is that the semantics of this function are not the same as of P_PointOnSide or P_PointOnDivLineside because it has to consider the special needs of the node builder. Please rewrite this to use P_PointOnDivLineSide. It may need a bit more setup but is the better choice here.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest