Page 1 of 1

Extend SKYEXPLODE flag for LineAttack

PostPosted: Fri Nov 02, 2018 3:56 am
by Cacodemon345
PR

Introduces:

    1. Extended behaviour for LineAttack function; puffs using SKYEXPLODE flag now puffs on skys.
    2. TRACE_HitSky flag; Makes Trace function return TRACE_HasHitSky should the Trace hit a sky floor or ceiling.

Re: Extend SKYEXPLODE flag for LineAttack

PostPosted: Fri Nov 02, 2018 3:57 am
by Nash
TRACE_HitSky sounds extremely useful. Do these take into account skies generated from Line_Horizon?

Re: Extend SKYEXPLODE flag for LineAttack

PostPosted: Fri Nov 02, 2018 3:58 am
by Rachael
I tested this by modifying BulletPuff directly on my copy of GZDoom. So far I cannot find any potential bugs it introduces, but it needs a second opinion.

I am able to damage monsters, and I was able to test both walls and skies. The puffs still disappear in the sky if the flag is not set, but it spawns a puff as expected with the flag. Thus, I am not able to find any issues, at least so far.

Re: Extend SKYEXPLODE flag for LineAttack

PostPosted: Fri Nov 02, 2018 3:59 am
by Cacodemon345
Nash wrote:TRACE_HitSky sounds extremely useful. Do these take into account skies generated from Line_Horizon?
Ehhh, I made the behaviour of TRACE_HitSky the same as how TRACE_NoSky behaves so that it works properly with LineAttack.

Re: Extend SKYEXPLODE flag for LineAttack

PostPosted: Sat Nov 03, 2018 9:25 am
by Cacodemon345
This should be closed now, as the PR has been merged.