[ZDBSP] Incorrect extended segs side information fix

Moderator: GZDoom Developers

Post Reply
User avatar
Altazimuth
Posts: 12
Joined: Wed Jan 08, 2014 11:56 am

[ZDBSP] Incorrect extended segs side information fix

Post by Altazimuth »

Posting this here for visibility, as I'm uncertain how much attention is paid to the ZDBSP repo (or if rheit/zdbsp is where PRs are supposed to be sent nowadays).
printz wrote:Because of a forgotten line of code which wasn't deleted, extended segs get the wrong "side" information when a linedef has the same sidedef repeated on both parts of the 2-sided wall. The line was safe to delete because clearly the side was just set inside both branches of the if block.
Pull request can be found here: https://github.com/rheit/zdbsp/pull/6
The fix is extremely small, just removal of lines 524 (blank line) and 525 of nodebuild_extract.cpp, which is:

Code: Select all

newseg.side = Level.Lines[org->linedef].sidenum[1] == org->sidedef ? 1 : 0;
Last edited by Altazimuth on Sat Oct 27, 2018 2:29 pm, edited 1 time in total.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [ZDBSP] Incorrect extended segs side information fix

Post by Graf Zahl »

I do not have commit access to that repository. I'd appreciate if the fix can be forwarded to my clone of it.
User avatar
Rachael
Posts: 13531
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: [ZDBSP] Incorrect extended segs side information fix

Post by Rachael »

@ Graf: I can talk to Randi if need be - who else would you like having access to it, if I do? And do you want me to accept that pull request? Nevermind, done.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [ZDBSP] Incorrect extended segs side information fix

Post by Graf Zahl »

Like I said, I already made a copy of it on my account. I'd rather have it there where it's under my control.
User avatar
Rachael
Posts: 13531
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: [ZDBSP] Incorrect extended segs side information fix

Post by Rachael »

Alright.
User avatar
Altazimuth
Posts: 12
Joined: Wed Jan 08, 2014 11:56 am

Re: [ZDBSP] Incorrect extended segs side information fix

Post by Altazimuth »

Thanks for the quick adoption!
Post Reply

Return to “Closed Feature Suggestions [GZDoom]”