[Added] [ZDBSP] Incorrect extended segs side information fix

Moderator: GZDoom Developers

[ZDBSP] Incorrect extended segs side information fix

Postby Altazimuth » Sat Oct 27, 2018 3:02 pm

Posting this here for visibility, as I'm uncertain how much attention is paid to the ZDBSP repo (or if rheit/zdbsp is where PRs are supposed to be sent nowadays).
printz wrote:Because of a forgotten line of code which wasn't deleted, extended segs get the wrong "side" information when a linedef has the same sidedef repeated on both parts of the 2-sided wall. The line was safe to delete because clearly the side was just set inside both branches of the if block.

Pull request can be found here: https://github.com/rheit/zdbsp/pull/6
The fix is extremely small, just removal of lines 524 (blank line) and 525 of nodebuild_extract.cpp, which is:
Code: Select allExpand view
newseg.side = Level.Lines[org->linedef].sidenum[1] == org->sidedef ? 1 : 0;
Last edited by Altazimuth on Sat Oct 27, 2018 3:29 pm, edited 1 time in total.
User avatar
Altazimuth
 
Joined: 08 Jan 2014

Re: [ZDBSP] Incorrect extended segs side information fix

Postby Graf Zahl » Sat Oct 27, 2018 3:16 pm

I do not have commit access to that repository. I'd appreciate if the fix can be forwarded to my clone of it.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [ZDBSP] Incorrect extended segs side information fix

Postby Rachael » Sat Oct 27, 2018 3:20 pm

@ Graf: I can talk to Randi if need be - who else would you like having access to it, if I do? And do you want me to accept that pull request? Nevermind, done.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: [ZDBSP] Incorrect extended segs side information fix

Postby Graf Zahl » Sat Oct 27, 2018 3:47 pm

Like I said, I already made a copy of it on my account. I'd rather have it there where it's under my control.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [ZDBSP] Incorrect extended segs side information fix

Postby Rachael » Sat Oct 27, 2018 4:00 pm

Alright.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: [ZDBSP] Incorrect extended segs side information fix

Postby Altazimuth » Sat Oct 27, 2018 6:02 pm

Thanks for the quick adoption!
User avatar
Altazimuth
 
Joined: 08 Jan 2014


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest