[Added] [ZDBSP] Incorrect extended segs side information fix

[Altazimuth]

Posting this here for visibility, as I'm uncertain how much attention is paid to the ZDBSP repo (or if rheit/zdbsp is where PRs are supposed to be sent nowadays).

Because of a forgotten line of code which wasn't deleted, extended segs get the wrong "side" information when a linedef has the same sidedef repeated on both parts of the 2-sided wall. The line was safe to delete because clearly the side was just set inside both branches of the if block.

Pull request can be found here: https://github.com/rheit/zdbsp/pull/6
The fix is extremely small, just removal of lines 524 (blank line) and 525 of nodebuild_extract.cpp, which is:

Code: Select all • Expand view

newseg.side = Level.Lines[org->linedef].sidenum[1] == org->sidedef ? 1 : 0;

[Graf Zahl]

I do not have commit access to that repository. I'd appreciate if the fix can be forwarded to my clone of it.

[Rachael]

@ Graf: I can talk to Randi if need be - who else would you like having access to it, if I do? And do you want me to accept that pull request? Nevermind, done.

[Graf Zahl]

Like I said, I already made a copy of it on my account. I'd rather have it there where it's under my control.

[Rachael]

Alright.

[Altazimuth]

Thanks for the quick adoption!